At least one core caller of the to-be-deprecated functions was missed before Gerrit change 92457 was merged: skins/common/protect.js (line 42) calls addClickHandler. Now that addClickHandler is nooped, clicking the checkbox no longer changes the form state.
Version: 1.22.0
Severity: normal
URL: https://test.wikipedia.org/wiki/Page393?action=protect&debug=true
I also see some calls to injectSpinner and removeSpinner in ./skins/common/upload.js.
Change 94161 had a related patch set uploaded by Krinkle:
Migrate usage of legacy wikibits in core
Change 94161 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94235 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94236 had a related patch set uploaded by Anomie:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94235 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94236 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94256 had a related patch set uploaded by Bartosz Dziewoński:
Migrate usage of wikibits in legacy protect.js and upload.js
Change 94256 merged by jenkins-bot:
Migrate usage of wikibits in legacy protect.js and upload.js