Page MenuHomePhabricator

Remove gadget modules from mw.loader.store when the user disables them
Closed, ResolvedPublic

Description

  1. Go to https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets and disable all gadgets except one which is loaded by ResourceLoader (e.g. "ShortDiff"), then save your changes
  2. Clear you browser cache and local storage
  3. Go to https://test.wikipedia.org/wiki/Special:BlankPage and take note of the list of gadget modules in the store:
$.grep( Object.keys( mw.loader.store.items ), function( m ){
    return m.indexOf( 'ext.gadget' ) !== -1; }
).join( '\n' )

In my case, this returned:

ext.gadget.ShortDiff@1347062400
  1. Go back to https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-gadgets and disable that gadget, and save your changes
  2. Check the list of modules in the storage again.
    • Expected result: The module of the gadget should be removed from local storage
    • Actual result: The module is still there, taking space

See Also: T66721: mw.loader.store should not occupy all of localStorage

Details

Reference
bz56778

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:19 AM
bzimport set Reference to bz56778.
bzimport added a subscriber: Unknown Object (MLST).
matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).
Krinkle renamed this task from Remove gadget modules from local storage when the user disables them to Remove gadget modules from mw.loader.store when the user disables them.Mar 24 2016, 6:38 PM
Krinkle lowered the priority of this task from Medium to Low.Dec 3 2016, 5:25 AM
Krinkle claimed this task.

No longer a problem since 2019 (change 528300, T229245).