Page MenuHomePhabricator
Create Task
Maniphest T58779

VisualEditor: The direction of the <textarea> in extension tags editor must correspond to the surrounding content direction
Closed, ResolvedPublic
Actions

Description

Currently, if I go to https://www.mediawiki.org/wiki/User:Amire80/ve-poem and edit it using VE, I can edit the content of the <poem> tag. If my UI language is Hebrew, then the <textarea> for editing the poem is RTL. I would expect it to be LTR.

Ideally the default direction for the <textarea> that this feature should be the direction of the surrounding text. If it's hard to get, then the direction of the page's content will probably suffice. (Currently it will be the same as the content language of the wiki, but it may change some day when we finally introduce page language.)

There can also be some tags for which the default direction must be different, such as <source>, but that's an issue for a separate bug.

Version: unspecified
Severity: normal

Details

Reference
bz56779

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:19 AM
• bzimport added projects: VE-deploy-2013-11-14, VisualEditor-EditingTools.
• bzimport set Reference to bz56779.
Amire80 created this task.Nov 8 2013, 2:14 PM
Amire80 added a comment.Nov 8 2013, 2:23 PM

From IRC:

<mooeypoo> what do you mean "must correspond to surrounding content direction?
<mooeypoo> of the <poem> ?
<mooeypoo> so, it should be content direction rather than GUI direction?
<aharoni> mooeypoo: It definitely shouldn't be the GUI direction. It has nothing to do with it.
<mooeypoo> nods
<aharoni> The direction of the inspector's GUI should be the GUI direction,
<aharoni> but the textarea needs the direction of the content.
<mooeypoo> yeah
<mooeypoo> makes sense, just wanted to make sure
<aharoni> Ideally, if the wiki is in English, but it's a <poem> tag inside <div lang="fa" dir="rtl">, then the textarea should be rtl.

Amire80 added a comment.Nov 8 2013, 2:28 PM

Related: Bug 56780.

gerritbot added a comment.Nov 8 2013, 3:56 PM

Change 94375 had a related patch set uploaded by Mooeypoo:
MWExtensionInspector input direction based on content

https://gerrit.wikimedia.org/r/94375

gerritbot added a comment.Nov 8 2013, 7:30 PM

Change 94375 merged by jenkins-bot:
MWExtensionInspector input direction based on content

https://gerrit.wikimedia.org/r/94375

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL