Page MenuHomePhabricator

VisualEditor: JS parse error appears while enabling few gadgets for editors
Closed, InvalidPublic

Description

Steps to reproduce:

1.Go to Preferences>Gadgets
2.Enable few gadgets.I tried enabling all the gadgets under "improved navigation" , Interface : Editing and uploads and Interface:Files and Categories

3.Now load the editor

Observed Result:
The following js error appears:

Error: JavaScript parse error: Parse error: Illegal token in file 'MediaWiki:Gadget-popups.js' on line 1221 Error {} load.php:145
log load.php:145
runScript load.php:154
checkCssHandles load.php:155
(anonymous function) load.php:155
fire load.php:12
self.fireWith load.php:14
self.fire load.php:14
addEmbeddedCSS load.php:149
(anonymous function)


Version: unspecified
Severity: normal

Details

Reference
bz56806

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:21 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz56806.

That sounds like a bug in the popups gadget. Which wiki was this on?

It was found in test2 environment

https://test2.wikipedia.org/w/index.php?title=MediaWiki:Gadget-popups.js&action=history is from Feb 2012.

Line 1221 is:
/*@if (@_jscript_version >= 5)

https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-popups.js&action=history for example is from Nov 2013 (but also contains that line).

Hence wondering if it's a "real" problem or just an ancient .js file on test2.