Page MenuHomePhabricator

MobileFrontend's "Mobile view" link in footer has duplicated &title= URL parameters and is not using a pretty URL
Closed, ResolvedPublic

Details

Reference
bz56837

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:24 AM
bzimport set Reference to bz56837.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1390

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1393

Thanks for filing this. I imagine this is a fairly recent regression.

Writing a bug description since this bug doesn't have one...

If you click the 'Mobile view' link from any desktop article on one of the cluster wikis, you get sent to a URL that has the title param set twice. For example:
https://de.m.wikipedia.org/w/index.php?title=Honigdachs&title=Honigdachs

Interestingly, if you're coming from a redirect, the first title is the canonical title and the second is the redirect title:
https://m.mediawiki.org/w/index.php?title=ResourceLoader/Default_modules&title=Mediawiki.ui#mediawiki.ui

This doesn't happen on my local wiki, so it may be configuration related.

Oof, definitely did not previously do this :( I'm able to replicate this on my local instance (Kaldari, I imagine you might not be able to replicate it because you do not have a separate mobile domain [wgMobileUrlTemplate] set up locally). I'll take a look.

Note that once this is deployed, it will take a while for the change to be reflected on *every* article in the WMF-hosted projects due to caching. Iirc, the TTL is 30 days, so it may take up to 30 days for the change to be ubiquitous.

Change 99270 had a related patch set uploaded by MZMcBride:
Ensure title arg isn't set twice when creating 'mobile view' link

https://gerrit.wikimedia.org/r/99270

Change 99270 merged by jenkins-bot:
Ensure title arg isn't set twice when creating 'mobile view' link

https://gerrit.wikimedia.org/r/99270