Page MenuHomePhabricator
Create Task
Maniphest T58901

Port unusedfiles.py to Pywikibot core
Closed, ResolvedPublic
Actions

Description

PyWikibot [1] is a Python-based framework to write bots for MediaWiki. There are currently 2 versions of pywikibot currently used:

  • version 1.0 (also known as pywikibot-compat) is the legacy version
  • version 2.0 (also known as pywikibot-core) is a rewrite of the original framework, focusing solely on MediaWiki wikis with an API (version 1.14 or newer) and offering an improved internal architecture.

There are a number of scripts used by various robot operators that were used in pywikibot-compat but have not yet been adapted to work with pywikibot-core. One of those is unusedfiles.py, which Finds unused media using [[Special:Unusedimages]].

You can find information about how to convert the script on [2], [3]. Patches can be submited through the gerrit uploader [4] (you need a MediaWiki.org account). More documentation on gerrit can be found at [5].

[1] https://www.mediawiki.org/wiki/Manual:Pywikibot
[2] https://www.mediawiki.org/wiki/Manual:Pywikibot/2.0/Conversion
[3] https://www.mediawiki.org/wiki/Manual:Pywikibot/i18n_conversion
[4] https://tools.wmflabs.org/gerrit-patch-uploader/
[5] http://www.mediawiki.org/wiki/Manual:Pywikipediabot/Gerrit

Version: unspecified
Severity: normal
Whiteboard: gci2013 https://www.mediawiki.org/wiki/Google_Code-In#Candidate_tasks

Details

Reference
bz56901

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:28 AM
• bzimport added projects: Pywikibot-General, good first task.
• bzimport set Reference to bz56901.
• bzimport added a subscriber: Unknown Object (????).
Strainu created this task.Nov 11 2013, 11:55 AM
• bzimport added a comment.Nov 20 2013, 10:39 PM

lettrich42 wrote:

I am a Google Code In Student who has accepted this Bug to conver unusedfiles.py from compat to core(https://google-melange.appspot.com/gci/task/view/google/gci2013/5799131951923200). Should I upload it to the original repository of pywikibot/compat, or to the pywikibot/core repository where it is ported to?

Strainu added a comment.Nov 20 2013, 10:46 PM

The file needs to get in pywikibot/core, so you need to generate a patch for that project.

• bzimport added a comment.Nov 20 2013, 10:59 PM

lettrich42 wrote:

Thanks fore the response. Sorry, but i seem to have another problem, and I got the dump from the Gerrit uploader:

Result from uploading patch:
git clone --depth=1 ssh://gerrit/pywikibot/core /tmp/1609560.1.webgrid/tmp5VqLtG Cloning into '/tmp/1609560.1.webgrid/tmp5VqLtG'... Total 254 (delta 84), reused 94 (delta 52) git rev-parse --abbrev-ref HEAD Will commit to branch: master git config user.name [[mw:User:Richardusername]] git config user.email gerritpatchuploader@gmail.com scp -p gerrit:hooks/commit-msg .git/hooks/ git apply < patch fatal: unrecognized input patch -p0 < patch patch: ** Only garbage was found in the patch input. patch -p1 < patch patch: ** Only garbage was found in the patch input.
Upload failed
Reason: Patch failed (is your patch in unified diff format, and does it patch apply cleanly to master?) (check log above for details)

I read about using git diff in the Gerrit tutorial, should I use it instead?

Strainu added a comment.Nov 20 2013, 11:16 PM

How did you generate your patch? Normally, the procedure I suggest is the following:

  • clone the pywikibot/core branch
  • add the file, make the modifications etc.
  • git add unusedfiles.py
  • git commit (make sure you write a good commit description)
  • git format-patch -1 HEAD

See http://stackoverflow.com/questions/6658313/generate-a-git-patch-for-a-specific-commit for details.

The git format-patch command will generate a patch file that you can then upload to gerrit.

• bzimport added a comment.Nov 23 2013, 5:04 PM

lettrich42 wrote:

https://gerrit.wikimedia.org/r/#/c/97016/

gerritbot added a comment.Nov 23 2013, 8:32 PM

Change 97016 had a related patch set uploaded by Richardll:
Ported unusedfiles.py from pywikibot compat to core

https://gerrit.wikimedia.org/r/97016

gerritbot added a comment.Nov 23 2013, 9:54 PM

Change 97016 merged by Strainu:
Ported unusedfiles.py to pywikibot/core, added unicode support.

https://gerrit.wikimedia.org/r/97016

Aklapper added a project: Pywikibot.Jun 29 2018, 3:17 PM
Restricted Application added a subscriber: Cyberpower678. · View Herald TranscriptJun 29 2018, 3:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL