Page MenuHomePhabricator

Gitblit backlink to mediawiki.org/wiki/Special:Code for old commits should be https
Closed, DeclinedPublic

Description

For old svn commits giblit provides a link to mediawiki.org/wiki/Special:Code, but that link is always http, please provide a https link.

If possible, this link should be clickable.

Thanks.

Example on:
https://git.wikimedia.org/commit/mediawiki%2Fcore/96906d6cd38ba7c1c5af81e05a30105e6a29414f


Version: wmf-deployment
Severity: trivial

Details

Reference
bz56953

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:32 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz56953.
bzimport added a subscriber: Unknown Object (MLST).

This is in puppet, easily fixed by anyone.

gitblit.config.erb is the file name is memory serves.

(In reply to comment #1)

This is in puppet, easily fixed by anyone.

gitblit.config.erb is the file

name is memory serves.

Have not found that file in operations/puppet and no other file with .erb which looks like this. I have only found the regex to link r???? to Special:Code (gerrit.config.erb), but this bug is not about that. Its about the refs/notes/commits.

Or is operations/puppet the wrong repo to search for that file?

greg set Security to None.
demon claimed this task.
demon subscribed.

Was fixed at some point.

It is not fixed, I still see a http link to www.mediawiki.org on the example above

The configuration says https, weird :\

Ahhhh, those. I see what you're talking about now. That's in refs/notes/* in the repo themselves and comes from the SVN migration days. Prior to HTTPS-everywhere. Those aren't editable at this point.

(I thought you meant the auto-linking of like r123 :)