Page MenuHomePhabricator

Close and Fullscreen button on MultimediaViewer should use embedded icon on CSS
Closed, ResolvedPublic

Description

Author: nzmoihue

Description:
This needed specially for users with lower internet speed to quickly close the overlay menu. It just need adding /* embed */ before https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/00e76b4a5d060cac535a9eba16a00f24d9940c5f/css/multilightbox.css#L50 and https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/00e76b4a5d060cac535a9eba16a00f24d9940c5f/css/ext.multimediaViewer.css#L70 (and a few other places) and ResouceLoader will take care of it.


Version: unspecified
Severity: minor

Details

Reference
bz56971

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:33 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz56971.
bzimport added a subscriber: Unknown Object (MLST).

The former file actually should be totally overridden by the latter.

Yay cascading! :)

Change 104325 had a related patch set uploaded by Apsdehal:
Added Data URI embedding feature trigger

https://gerrit.wikimedia.org/r/104325

I don't see any non-embedded references at the moment, except in multilightbox.css which get overriden (and refer to non-existent files anyway).

Change 104325 abandoned by Gilles:
Added Data URI embedding feature trigger

Reason:
I'm pretty sure all images in MV's CSS are embedded now.

https://gerrit.wikimedia.org/r/104325

Gilles raised the priority of this task from Low to Unbreak Now!.Dec 4 2014, 10:12 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Low.Dec 4 2014, 11:23 AM