Page MenuHomePhabricator

VisualEditor: Pawn ("♙") appears when clicking into the blank space above a new link inspector and inserting content
Closed, ResolvedPublic

Description

Steps:

  • Edit page
  • Add heading "External links"
  • Press Enter, click "Bulleted list" in toolbar
  • Click on the link tool and paste a url in the link input widget
  • Type a label where the cursor is

Expected:

<h2>External links
<ul><li> <a>Typing</a>

Actual:

<h2>External links
<ul><li> <a>http://example.org/foobarTyping</a>♙


Version: unspecified
Severity: normal

Details

Reference
bz56976

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:34 AM
bzimport set Reference to bz56976.

Is there a JS error or exception in the console?

(In reply to comment #1)

Is there a JS error or exception in the console?

There is not.

Reduced steps:

Steps:

  • Edit page with a list (or create a new unordered list)
  • Create a new list item
  • Click on the link tool and enter a url (e.g. "http://example.org") in the link input widget
  • Type a label (e.g. "example") where the cursor is

Expected:
<a href="http://example.org">example</a>

Actual:
<a href="http://example.org">http://example.orgxample</a>♙

Note how the first character typed was ignored.

Clarification:

  • Create an empty list item
  • Open the link inspector
  • Type a link target
  • CLICK to position the cursor at the SAME PLACE where it was before
  • The inspector DOES NOT close
  • Type
  • The first key press is ignored and inserts a pawn instead, the remaining key presses insert characters before the pawn

Root cause: when the document is focused, the inspector should close. We currently close the inspector when the selection changes, and usually clicking out of the inspector does change the selection, but in creation mode this isn't necessarily true.

Change 98116 had a related patch set uploaded by Catrope:
Close inspectors when surface is focused but selection doesn't change

https://gerrit.wikimedia.org/r/98116

Change 98116 merged by jenkins-bot:
Close inspectors when surface is focused but selection doesn't change

https://gerrit.wikimedia.org/r/98116