Page MenuHomePhabricator

migrate mediawiki/tools/codesniffer to deployment system
Closed, ResolvedPublic

Description

mediawiki/tools/codesniffer hold the MediaWiki style standard for PHP CodeSniffer. It is currently deployed as a submodule of integration/jenkins.git which is not ideal and error prone. Instead we should deploy it using the Wikimedia deployment system:

  • in puppet add entry for mediawiki/tools/codesniffer to integration/codesniffer
  • update jenkins jobs / slave scripts to point to the new path (something like /srv/deployment/integration/codesniffer/...)

Version: wmf-deployment
Severity: normal

Details

Reference
bz57064

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:40 AM
bzimport set Reference to bz57064.
bzimport added a subscriber: Unknown Object (MLST).

Change 95446 had a related patch set uploaded by Hashar:
deployment: mediawiki/tools/codesniffer for Jenkins CI slaves

https://gerrit.wikimedia.org/r/95446

Change 95446 merged by Ori.livneh:
deployment: mediawiki/tools/codesniffer for Jenkins CI slaves

https://gerrit.wikimedia.org/r/95446

The standard is now deployable with git-deploy /srv/deployment/integration/mediawiki-tools-codesniffe . I did the initial sync to the Jenkins slaves.

Still have to update the scripts / macros.

Change 95531 had a related patch set uploaded by Hashar:
run-phpcs-mw: point to standard deployed via git-deploy

https://gerrit.wikimedia.org/r/95531

Change 95531 merged by jenkins-bot:
run-phpcs-mw: point to standard deployed via git-deploy

https://gerrit.wikimedia.org/r/95531

uninstalled phpcs from gallium:

root@gallium:~# pear uninstall PHP_CodeSniffer
uninstall ok: channel://pear.php.net/PHP_CodeSniffer-1.4.7

All jobs are using the phpcs shell wrapper.