Page MenuHomePhabricator

clean up obsolete VE API dependency
Closed, ResolvedPublic

Description

AIUI, Flow no longer uses VE's API to convert from/to wikitext/html, it posts API requests to Parsoid's URL if its available.

I think this means:

  • Hooks.php onSetupAfterCache() is obsolete, (and has been since we occupied namespaces?!),
  • Flow should have its own parameters $wgFlowParsoidURL, $wgFlowParsoidPrefix, $wgFlowParsoidTimeout which in comments can default to the $wgVisualEditor* values.
  • Clean up obsolete comments in ParsoidUtils.php

This will make it clearer that Flow can work with Parsoid even if the VisualEditor extension isn't installed.

(Is the Parsoid extension even required on MediaWiki servers in a cluster arrangement where only one machine runs the Parsoid nodejs service?) I guess yes in order to "trigger Parsoid cache updates".)


Version: master
Severity: minor

Details

Reference
bz57111

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:14 AM
bzimport set Reference to bz57111.
bzimport added a subscriber: Unknown Object (MLST).

Coincidentally, I had been working on that yesterday: https://gerrit.wikimedia.org/r/#/c/95605/

onSetupAfterCache still needs to be removed in there, though.

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/470, but people from the community are welcome to contribute here and in Gerrit.

Change 95605 had a related patch set uploaded by Matthias Mullie:
(bug 57111) clean up obsolete VE API dependency

https://gerrit.wikimedia.org/r/95605

Change 95605 merged by jenkins-bot:
(bug 57111) clean up obsolete VE API dependency

https://gerrit.wikimedia.org/r/95605