Flow: syntax highlighting tags (GeSHi) don't get styled
Open, MediumPublic
Actions

Assigned To

None

Authored By

	• MZMcBride
	Nov 18 2013, 4:49 AM

Description

Syntax highlighting doesn't work with Flow.

Example input:

<syntaxhighlight lang="css">
.foo {
    font-weight: bold;
}
</syntaxhighlight>

Output is not appropriately highlighted: https://www.mediawiki.org/wiki/Topic:Sb29d13fybslwgjh
It should look like this: https://www.mediawiki.org/w/index.php?title=User:Quiddity_%28WMF%29/sandbox&oldid=1397603

TheDJ notes (in comment below) that this might be related (plus its blockers): T69540: Produce/preserve the metadata about additional ResourceLoader modules required by extension tags

Details

Reference: bz57159

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T59159 Flow: syntax highlighting tags (GeSHi) don't get styled
		Open		None	T93838 Add CSS modules that Parsoid tells us are relevant

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:17 AM

• bzimport added a project: StructuredDiscussions.

• bzimport set Reference to bz57159.

• bzimport added a subscriber: Unknown Object (MLST).

• MZMcBride created this task.Nov 18 2013, 4:49 AM

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/475, but people from the community are welcome to contribute here and in Gerrit.

another example at https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&workflow=050c27a75b2dcc146adc842b2b77e796#flow-post-050c27dd37d200e9aae290b11c2788d8

which is copied from https://www.mediawiki.org/wiki/Talk:About_Beta_Features#HTML

(possibly the same as bug 55533 ("VisualEditor: MWSyntaxHighlight* is badly broken") ?)

TheDJ notes, "ah, I see that Resourceloader modules don't work yet :)".[1]

So perhaps this bug should be expanded to cover that?
I'll leave that up to the devs.

[1] at https://www.mediawiki.org/w/index.php?title=Talk:Flow&workflow=rxtlvx7tsc2qqf1b#flow-post-ry5zwru18qpuglqk

On trello at https://trello.com/c/qb7ulCmy/

Flow needs 2 things here. When rendering the original page, it needs to pick up the resources and add them into the parser output, so they end up on the head. Additionally, they need to be transferred in api results, preferably similar to how action=parse does it for prop=modules.

This is probably closely related to bug 67540:

And specifically you might want to look at one of it's blockers:
Bug 51245, bug 58388 and bug 67515 which detail similar problems for VE..

I just noticed this problem on Portuguese Wikipedia too:
https://pt.wikipedia.org/w/index.php?title=T%C3%B3pico:Sav6mxon1ianxj4l&topic_showPostId=sb8xryegdo65sq73#flow-post-sb8xryegdo65sq73

• Mattflaschen-WMF added a project: SyntaxHighlight.Feb 5 2015, 7:36 PM

• Mattflaschen-WMF subscribed.

He7d3r updated the task description. (Show Details)Feb 5 2015, 7:36 PM

He7d3r removed a project: SyntaxHighlight.

He7d3r set Security to None.

He7d3r removed a subscriber: • Mattflaschen-WMF.

• Mattflaschen-WMF renamed this task from Flow: syntax highlighting doesn't work to Flow: syntax highlighting tags (GeSHi) don't work.Feb 5 2015, 7:36 PM

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added a project: SyntaxHighlight.

• Mattflaschen-WMF subscribed.

Quiddity updated the task description. (Show Details)Feb 6 2015, 6:11 AM

Quiddity updated the task description. (Show Details)Mar 21 2015, 12:08 AM

Quiddity added a project: Collaboration-Team-Triage.

Quiddity merged a task: T93516: SyntaxHighlight in Flow pages.Mar 22 2015, 5:52 PM

Quiddity added subscribers: Aklapper, Vriullop.

• Spage unsubscribed.Apr 6 2015, 8:35 PM

Legoktm merged a task: T101827: Extension:SyntaxHighlight_GeSHi does not work in Flow.Jun 22 2015, 11:44 PM

Legoktm added a subscriber: Gerardduenas.

Ricordisamoa subscribed.Jul 6 2015, 7:54 PM

• Mattflaschen-WMF added a subtask: T69540: Produce/preserve the metadata about additional ResourceLoader modules required by extension tags.Oct 23 2015, 3:27 PM

• Mattflaschen-WMF renamed this task from Flow: syntax highlighting tags (GeSHi) don't work to Flow: syntax highlighting tags (GeSHi) don't get styled.May 19 2016, 6:51 PM

• Mattflaschen-WMF merged a task: T135735: #tag:syntaxhighlight is not interpreted in Flow.May 19 2016, 10:00 PM

• Mattflaschen-WMF added subscribers: VIGNERON, Trizek-WMF, Zppix.

Another example from hewiki:
https://he.wikipedia.org/wiki/%D7%A0%D7%95%D7%A9%D7%90:T8azrr7jamnrqfuy

• DannyH unsubscribed.Jul 25 2016, 4:36 PM

• Mattflaschen-WMF mentioned this in T140920: <mapframe> is not visible in Flow (blank frame).Jul 25 2016, 10:21 PM

I'm having the same problem.

All codes is not styled.

In the log, nothing is printed.

Any help?

• Mattflaschen-WMF unsubscribed.Nov 1 2016, 3:16 PM

PauloSincos unsubscribed.May 19 2017, 11:12 AM

Trizek-WMF mentioned this in T167928: Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt.Jun 23 2017, 8:13 AM

Volker_E awarded a token.Jul 27 2017, 1:20 PM

Volker_E rescinded a token.

Volker_E removed a subscriber: • wikibugs-l-list.

Volker_E subscribed.

Liuxinyu970226 merged a task: T173301: SyntaxHighlight extension in 1.29.0 does not highlight Lua language.Aug 20 2017, 10:49 PM

Liuxinyu970226 added a subscriber: aka_sektor.

Liuxinyu970226 subscribed.Aug 22 2017, 8:34 AM

Release new MW version 1.29.1: https://www.mediawiki.org/wiki/Release_notes/1.29#MediaWiki_1.29.1

Bug with syntax highlight fixed?

Setup 1.29.1: https://releases.wikimedia.org/mediawiki/1.29/mediawiki-1.29.1.tar.gz

Bug with syntax highlight - stiil not fixed.

@aka_sektor: The status of this task is "open", see the upper corner. Hence this issue is not fixed and we all know that. :) No need to comment and tell. If you would like to contribute a code change to fix this problem, you are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit.

@Aklapper : Just let them return it as it was in 1.28.2
I do not know what exactly they broke.

In T59159#3548628, @aka_sektor wrote:

@Aklapper : Just let them return it as it was in 1.28.2
I do not know what exactly they broke.

I only know that this problem affects board too: https://www.mediawiki.org/w/index.php?title=Flow/Sandbox&header_revId=twwnd0zvz6kx6bhb&action=view-header

Any news?

T174374: Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage may solve this task. I'll ask.

News? Solutions? Anything?

Ok. I make rollback to 1.28.2
No one fixes the bug.

aka_sektor unsubscribed.Oct 9 2017, 6:09 PM

IKhitron subscribed.Oct 19 2017, 5:07 PM

Note: the ResourceLoader module missing is ext.pygments. You can load it unconditionally using mw.loader.load( 'ext.pygments' ), and I guess you could add this to your common.js to work around this bug if it’s very important :)

EBernhardson unsubscribed.Jul 18 2018, 7:05 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 7:05 PM

SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:11 PM

Liuxinyu970226 unsubscribed.Sep 27 2018, 12:27 PM

Krinkle awarded a token.Mar 18 2021, 12:50 AM

As a recent example, this can be seen at https://www.mediawiki.org/wiki/Topic:W5dh34nv202fzq7f.

In T59159#6923746, @Krinkle wrote:

As a recent example, this can be seen at https://www.mediawiki.org/wiki/Topic:W5dh34nv202fzq7f.

Other examples of likely affected features include Cite <ref>, Math, WikiHiero, TemplateData docs, TimedMediaHandler video player, 3D graphics, and more (Codesearch)