Page MenuHomePhabricator

attribute names should be treated case insensitive
Closed, ResolvedPublic

Description

Per http://www.w3.org/TR/html-markup/documents.html#case-insensitivity
attribute names should be treated case insensitive

And they are not because:
In https://parsoid.wmflabs.org/enwiki/Channel_Tunnel?oldid=581851617 you have ROWSPAN and COLSPAN and these do not seem to get interpreted by parsoid. This is easily witnessed if you set "border=1" on the table using a web inspector.


Version: unspecified
Severity: normal

Details

Reference
bz57251

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:23 AM
bzimport added a project: Parsoid-DOM.
bzimport set Reference to bz57251.

Change 99018 had a related patch set uploaded by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/99018

Good catch! We actually forgot to lowercase all attributes before checking them against the attribute whitelist in the sanitizer. That is now fixed.

We still don't preserve the case when serializing without selser. Whether that is an issue in practice remains to be seen.

Change 99018 merged by jenkins-bot:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/99018

Change 101278 had a related patch set uploaded by GWicke:
Merge "Bug 57251: Lowercase attributes before sanitization"

https://gerrit.wikimedia.org/r/101278

Change 101330 had a related patch set uploaded by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/101330

Change 101278 merged by GWicke:
Merge "Bug 57251: Lowercase attributes before sanitization"

https://gerrit.wikimedia.org/r/101278

Change 101330 merged by GWicke:
Bug 57251: Lowercase attributes before sanitization

https://gerrit.wikimedia.org/r/101330