Page MenuHomePhabricator

textarea problems when editing existing header or post
Closed, ResolvedPublic

Description

If you edit an existing header or post in Firefox and Chromium in wiki text mode,

  • The textarea starts out two lines tall regardless of how many lines of text it contains.
  • The textarea has no scrollbar regardless of how many lines of text it contains.
  • The textarea has no resize grabber handle.

The moment you press a key in the textarea (even an arrow key), it autosizes to its contents, which is good but

  • It autosizes regardless of the window size or scroll position.
  • There seems no limit to how big the textarea gets.
  • After I Cancel or Submit changes of a 130-line textarea, the original post (probably much less tall) doesn't scroll into view, I'm left at some random point in the document.
    • (And because there are dozens of empty comment areas on the board with my name, I can't search on my username to find my just-edited post, but that's a different issue.)

I think most of these are side-effects of the fix for bug 56131 "reply and edit text boxes do not expand." There are many jquery.*resize* libraries addressing this, Benny comments "we used jquery.elastic for Moodbar." (FWIW, ooui doesn't seem to support this.)

While I'm here, I also note that clicking the pencil icon to edit the header or a post does not set the input focus to the textarea. It should, and that might fix some issues.


Version: master
Severity: normal

Details

Reference
bz57275

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:25 AM
bzimport set Reference to bz57275.
bzimport added a subscriber: Unknown Object (MLST).

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/496, but people from the community are welcome to contribute here and in Gerrit.

Change 96636 had a related patch set uploaded by Bsitu:
Textarea should auto-expand to content height during initial load

https://gerrit.wikimedia.org/r/96636

Change 96636 merged by jenkins-bot:
Textarea should auto-expand to content height during initial load

https://gerrit.wikimedia.org/r/96636

Change 98497 had a related patch set uploaded by Matthias Mullie:
Alternative method to focus textarea

https://gerrit.wikimedia.org/r/98497

Assuming this bug is FIXED as all patches were merged.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.