Page MenuHomePhabricator

"Notes" section says "private" even when public
Closed, ResolvedPublic

Description

Example: https://meta.wikimedia.org/wiki/Special:AbuseFilter/71
The "description" says "publicly viewable", but the "Notes" are "private". If you log out, you can confirm that the notes are actually public, so I believe the message should be changed.


Version: master
Severity: minor

Details

Reference
bz57305

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
bzimport set Reference to bz57305.

(In reply to comment #0)

[...] so I believe
the message should be changed.

Or removed.

Change 104761 had a related patch set uploaded by 01tonythomas:
Reworded visibility status of "Notes" section to 'publicly viewable'

https://gerrit.wikimedia.org/r/104761

the notes are private, but only if the filter is set to private ("Hide details of this filter from public view"), but the description (also known as filter-title) is then still visible for everyone. That's the explanation of "private".

(In reply to comment #3)

the notes are private, but only if the filter is set to private ("Hide
details
of this filter from public view"), but the description (also known as
filter-title) is then still visible for everyone. That's the explanation of
"private".

The "Conditions" section doesn't include any mention about being public or private, and has the same visibility than the "Notes" section, so I suggest to simply remove the "(private)" text from the message.

(In reply to comment #4)

(In reply to comment #3)

the notes are private, but only if the filter is set to private ("Hide
details
of this filter from public view"), but the description (also known as
filter-title) is then still visible for everyone. That's the explanation of
"private".

The "Conditions" section doesn't include any mention about being public or
private, and has the same visibility than the "Notes" section, so I suggest
to
simply remove the "(private)" text from the message.

Removed.

Change 104761 merged by jenkins-bot:
Removed visibility status of "Notes" section

https://gerrit.wikimedia.org/r/104761