Page MenuHomePhabricator

CirrusSearch should move all of its search updates to the job queue
Closed, ResolvedPublic

Description

CirrusSearch should move all of its search updates to the job queue.


Version: unspecified
Severity: normal
Whiteboard: cirrus_reenable

Details

Reference
bz57316

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:28 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz57316.

If we're only tying into LinksUpdate behavior, we'll need to make sure we handle moves/deletions ok still.

I kind of hate SearchUpdate anyway, so I'm fine with ditching it.

Chad informs me that this shouldn't affect users very much; this will move Cirrus from instant updating to it taking a few seconds (or, worst case, minutes), which is still a gigantic improvement over Lucene's once-per-day update.

For those following along at home the advantage to this is that if something horrible happens to Elasticsearch then users don't don't end up waiting around for it to recover. We're already getting most of the way there with Bug 57215 but this makes double sure of it. It also allows some cleanup from a code standpoint which is nice too.

Change 96898 had a related patch set uploaded by Manybubbles:
Perform Elasticsearch updates with queued jobs

https://gerrit.wikimedia.org/r/96898

Change 96898 merged by jenkins-bot:
Perform Elasticsearch updates with queued jobs

https://gerrit.wikimedia.org/r/96898