Page MenuHomePhabricator

Clicking this page has issues in editor preview incorrectly throws confirm message
Closed, DeclinedPublic

Description

  • Go to https://en.m.wikipedia.org/wiki/Justin_Mikolo-Kinzonzi on another page whic has issues.
  • Click edit
  • Get to preview
  • Click this page has issues in preview and you are asked if you are sure you want to navigate away
  • Click okay, then close issues overlay and you are back in editor. Confirm lied!

Expected: No confirm message should be shown.


Version: unspecified
Severity: normal

Details

Reference
bz57328

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:29 AM
bzimport set Reference to bz57328.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1431

If you are in Beta mode, the alert is accurate. If you are in stable mode, it is not accurate.

Which behavior is actually the desired behavior? Is the behavior in Beta a bug or a feature?

I guess the answer to this is if you are an editor editing a page with issues and you are adding/removing an issue template - you should be able to verify the result is as expected and view the issues. Clicking the issues should not throw an alert and closing the issues overlay should return you to the preview window from where you can save.

So it sounds like there are actually 2 bugs here:

  1. In beta mode, opening and closing "This page has issues" causes you to lose your edit.
  2. In stable mode, the alert is not accurate.

Created a new bug for issue #2 at bug 58304.

To clarify /this/ bug is about issue #2 which is the current behaviour in stable. Since we are planning to push a new overlay design to stable I'm going to WONTFIX this in favour of fixing bug 58304.