Page MenuHomePhabricator

#display_point should not set a zoom if coordinates are null
Closed, ResolvedPublic

Description

Hi,

You can see the issue here:

http://semantic-mediawiki.org/wiki/Yaron%27s_location

This page calls a template, which calls #display_point - the "coordinates" parameter is set to null, while the "zoom" parameter is set to 7. So, what shows up on the map is a highly-zoomed view of a location somewhere off the coast of Africa. Instead, if the coordinates (or address, etc.) are null, I would think #display_point should ignore the "zoom" parameter, and always set to it the lowest zoom level, i.e. show the whole world.


Version: unspecified
Severity: normal

Details

Reference
bz57337

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:29 AM
bzimport set Reference to bz57337.
bzimport added a subscriber: Unknown Object (MLST).

This is a feature, not a bug! :)

If the change is made that you suggest, then one is no longer able to show a map of some region without placing any markers on it.

While I think changing the current default behaviour is not a good idea, adding a new feature for this could work. Semantic Maps by default simply does not show the map if there are no results, and there this behaviour can be toggled using the "forceshow" parameter. Feel free to file an enhancement request.

This doesn't make sense to me - there's no way that a null value for coordinates, address, etc. is meant to be a directive to show the location at "0, 0". Surely a null value here merits some special handling?

Hi - thanks for re-opening this bug; although labeling it as an enhancement doesn't make sense to me. If no point/center is set, showing the entire world seems reasonable, and so does not showing a map at all - but I just can't imagine that showing some islands off the coast of Africa would ever be considered ideal behavior.

I'm changing this back to severity "normal", from "enhancement" - sorry, I don't think there's any way that the current behavior can be considered correct.