Page MenuHomePhabricator

isDirty is getting saved
Closed, ResolvedPublic

Description

When I change ime settings and save I see the following:
action:options
format:json
optionname:uls-preferences
optionvalue:{"ime":{"isDirty":true,"language":"de","previousLanguages":["fi","de","eo","ml","avk"],"imes":{"en":"ipa-sil","fi":"fi-transliteration","ru":"ru-kbd","ml":"system","eo":"system","de":"system"},"enable":true,"previousInputMethods":["fi-transliteration","fi-transliteration","de-transliteration","ml-inscript2","ml-inscript2"]},"webfonts":{"fonts":{"fi":"system","en":"system","de":"system","ta":"Thenee","hi":"system"}}}

I think "isDirty" isn't supposed to be saved there.


Version: master
Severity: normal

Details

Reference
bz57349

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:30 AM
bzimport set Reference to bz57349.

Change 97496 had a related patch set uploaded by Santhosh:
Do not save isDirty field in preferences

https://gerrit.wikimedia.org/r/97496

Change 97496 merged by jenkins-bot:
Do not save isDirty field in preferences

https://gerrit.wikimedia.org/r/97496