Page MenuHomePhabricator
Create Task
Maniphest T59350

Overlay footer always links to untranslated [[Special:Notifications]]
Closed, ResolvedPublic
Actions

Description

Author: mr.heat

Description:
The "All notifications" ([[MediaWiki:Echo-overlay-link]]) link in the footer of the overlay always uses the untranslated special page name [[Special:Notifications]] in all Wikipedia languages.

This is only a cosmetic issue but should be fixed for consistency.

Version: master
Severity: trivial

Details

Reference
bz57350
SubjectRepoBranchLines +/-
Link to localized Special:Notifications in overlay footermediawiki/extensions/Echomaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:30 AM
• bzimport added projects: Notifications, I18n.
• bzimport set Reference to bz57350.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Nov 21 2013, 12:44 PM
Legoktm added a comment.Nov 21 2013, 4:31 PM

Relevant code is at https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/modules/overlay/ext.echo.overlay.js#L208

Legoktm added a comment.Dec 1 2013, 8:10 PM
  • Bug 57795 has been marked as a duplicate of this bug. ***
matmarex added a comment.Dec 1 2013, 8:13 PM

The badge itself already links to that special page, and the link there is localised. Just reuse it?

• werdna unsubscribed.Dec 10 2014, 6:16 PM
Legoktm added a project: good first task.Jul 6 2015, 8:44 AM
Legoktm set Security to None.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 8:44 AM
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 8:44 AM
gerritbot subscribed.Jul 7 2015, 12:58 AM

Change 223215 had a related patch set uploaded (by Legoktm):
Link to localized Special:Notifications in overlay footer

https://gerrit.wikimedia.org/r/223215

gerritbot added a project: Patch-For-Review.Jul 7 2015, 12:58 AM
Legoktm claimed this task.Jul 7 2015, 1:00 AM
Legoktm moved this task from Needs code to In progress on the Notifications board.
gerritbot added a comment.Jul 7 2015, 1:23 AM

Change 223215 merged by jenkins-bot:
Link to localized Special:Notifications in overlay footer

https://gerrit.wikimedia.org/r/223215

Legoktm mentioned this in rMEXT55c771eaaedc: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Jul 7 2015, 1:23 AM
Legoktm mentioned this in rECHObce9dbab1827: Link to localized Special:Notifications in overlay footer.
Legoktm closed this task as Resolved.Jul 7 2015, 1:44 AM
• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 7 2015, 2:00 AM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jul 8 2015, 11:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL