Page MenuHomePhabricator

Enhance hooks.rb in mediawiki-selenium gem to warn when BROWSER_LABEL is undefined
Closed, InvalidPublic

Description

Author: jhall

Description:
This is a follow-up to this recent change to the VisualEditor browser tests:

https://gerrit.wikimedia.org/r/#/c/96793/

Since a user may neglect to explicitly export a value for the BROWSER_LABEL environment variable, it might be a good idea to enhance hooks.rb for the mediawiki-selenium RubyGem to add a warning where that value is undefined.

The danger is that where the BROWSER_LABEL value is undefined, individual tests will not target the intended wiki pages, since those pages are expected to have the BROWSER_LABEL string included in the page URL.

The hooks.rb file already issues similar warnings for the MEDIAWIKI_USER and MEDIAWIKI_PASSWORD variables in the "Before('@login')" method:

https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki/selenium/hooks.rb


Version: unspecified
Severity: normal

Details

Reference
bz57363

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:31 AM
bzimport set Reference to bz57363.
bzimport added a subscriber: Unknown Object (MLST).

jhall wrote:

This task is invalid now that warnings for undefined BROWSER, PLATFORM and VERSION environment variable values have been added to env.rb in the most recent versions of the mediawiki_selenium Rubygem, so closing this ticket as INVALID.