Page MenuHomePhabricator
Create Task
Maniphest T59373

API action=centralnoticequerycampaign does not work for campaigns with spaces
Closed, ResolvedPublic
Actions

Description

For example see:
https://meta.wikimedia.org/wiki/Special:ApiSandbox#action=centralnoticequerycampaign&format=json&campaign=Trademark%20policy%20discussion
Expected: it should find the campaign called "Trademark policy discussion" [https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail&notice=Trademark+policy+discussion]
Actual result: it only looks for the first word, "Trademark"
It does not seem to work with underscores ('_'), pluses ('+'), minuses/en-dashes ('-') or spaces (' '/'%20').

Version: unspecified
Severity: normal

Details

Reference
bz57373

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:32 AM
• bzimport added projects: MediaWiki-extensions-CentralNotice, good first task.
• bzimport set Reference to bz57373.
• bzimport added a subscriber: Unknown Object (MLST).
PiRSquared17 created this task.Nov 21 2013, 9:24 PM
PiRSquared17 added a comment.Nov 21 2013, 9:27 PM

(In reply to comment #0)

It does not seem to work with underscores ('_'), pluses ('+'),
minuses/en-dashes ('-') or spaces (' '/'%20').

To clarify, it does work with characters like '-', but I can't figure out any reasonable way to encode spaces and get the proper result. I thought underscores or pluses would work, but no...

gerritbot added a comment.Nov 23 2013, 1:22 AM

Change 97170 had a related patch set uploaded by Aude:
Allow query campaign api to work for campaigns with space in their names

https://gerrit.wikimedia.org/r/97170

gerritbot added a comment.Nov 25 2013, 6:09 PM

Change 97170 merged by Mwalker:
Allow query campaign api to work for campaigns with space in their names

https://gerrit.wikimedia.org/r/97170

Aklapper added a comment.Dec 17 2013, 10:36 AM

Patch was merged; hence closing as FIXED. Please reopen if more work is needed.

Yair_rand mentioned this in T244806: API action=centralnoticequerycampaign does not work for campaigns with ampersands.Feb 10 2020, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL