Page MenuHomePhabricator

VisualEditor: Adding external link (wikitext style) should trigger wikitext warning
Closed, DeclinedPublic

Description

In the linked diff I added an external link within single brackets.
It didn't trigger the markup warning - I wouldn't know how to add such links in VE.
The markup guide for en.wp says these links are "Only used within article body for footnotes", but of course they might be used also outside ns0.


Version: unspecified
Severity: enhancement
URL: https://en.wikipedia.org/w/index.php?title=User%3AElitre_%28WMF%29%2Fsandbox&diff=582808389&oldid=582806629
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57419

Details

Reference
bz57418

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:35 AM
bzimport set Reference to bz57418.

Steps:

  1. Edit page
  2. Add [http://example.org]

Yep, we should change our wikitext detection to account for external links. Widening scope of this bug for external links in general, not just unnamed ones.

Steps:

  1. Edit page
  2. Add [http://example.org Foo] (unnamed external link)
  3. Add [http://example.org] (named external link)

(In reply to comment #0)

[..] I wouldn't know how to add such links in VE.

VisualEditor currently doesn't allow (external) links to be created without names. It can edit them (afaik), but not create new ones. This is a separate issue from the wikitext warning not being triggered though.

(As far as I tested, it can't edit them, that's why I filed bug 57419.)

I worry that this would interfere with languages which use []s rather than ()s in text – remember that the wikitext warning is for rare, occasional chiding comments for users who've temporarily forgotten that they're using a rich editor rather than wikitext.

If you want to write "using sites like Amazon [http://amazon.com and its local country variants] or eBay [http://ebay.com etc.]" you're going to be rather annoyed by this…

On reflection, I'm WONTFIXing this as it'd be too disruptive for a temporary notice.