Page MenuHomePhabricator

ERROR! It seems this job introduced a regression although it might be caused by a previous commit.
Closed, ResolvedPublic

Description

https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/3488/console : ERROR! It seems this job introduced a regression although it might be caused by a previous commit. in 3m 32s

This is happening on almost every commit, even ones which don't even touch PHP files. Please unfuck this up, I'm fed up with these stupid false errors and ignoring possibly real ones.


Version: unspecified
Severity: major

Details

Reference
bz57488

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:40 AM
bzimport set Reference to bz57488.
bzimport added a subscriber: Unknown Object (MLST).

the issue seems to be introduced with https://gerrit.wikimedia.org/r/#/c/74170/ although I am not quite sure why.

Possibly the regression tests are being run with $wgDevelopmentWarnings = false or something is different with how they are run (e.g. without --group) that is causing the issue. The issue does not appear with the gate-submit and other jobs.

wfWarn is supposed to throw a warning with $wgDevelopmentWarnings and we have phpunit converting warnings, notices and errors to exceptions.

convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"

Change 97352 had a related patch set uploaded by Aude:
Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests

https://gerrit.wikimedia.org/r/97352

Change 97352 merged by jenkins-bot:
Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests

https://gerrit.wikimedia.org/r/97352

Approved the change, looks good now.

Truly, this seems to have stopped the madness. Aude, you are my favorite person right now.