Page MenuHomePhabricator
Create Task
Maniphest T59529

XML format change
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In test.wikidata.org when I use "wbgetentities" the xml is
<entities><Q14 pageid="117" ns="0" title="Q14" lastrevid="2419" modified="2013-11-22T19:09:23Z" id="Q14" type="item">.... without <entity pageid="138" ...>

Version: master
Severity: blocker

Details

Reference
bz57529
SubjectRepoBranchLines +/-
Fix ApiXmlFormatTest and raw mode handling in apimediawiki/extensions/Wikibasemaster+48 -31
Update Wikidata - fix api xml / raw mode handlingmediawiki/extensions/Wikidatawmf/1.26wmf16+47 -31
Fix ApiXmlFormatTest and raw mode handling in apimediawiki/extensions/Wikibasewmf/1.26wmf16+43 -27
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:15 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz57529.
• bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher created this task.Nov 25 2013, 10:51 AM
Addshore added a comment.Nov 25 2013, 11:01 AM

This break was caused by https://gerrit.wikimedia.org/r/#/c/94930

Addshore added a comment.Nov 25 2013, 11:33 AM

Patches https://gerrit.wikimedia.org/r/#/q/I56020585c1f61e983189108e32b05eb96ec06838,n,z

Ricordisamoa subscribed.Jul 30 2015, 11:48 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 30 2015, 11:48 AM
Lydia_Pintscher reopened this task as Open.Jul 30 2015, 6:57 PM

Reopening this as Succu said on the contact the dev team page that it is happening again.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2015, 6:57 PM
aude subscribed.Jul 30 2015, 8:40 PM

git bisect (can confirm) tells me that https://gerrit.wikimedia.org/r/#/c/223794/ is where it broke

aude added a comment.Jul 31 2015, 1:20 AM

https://gerrit.wikimedia.org/r/#/c/228184/ fixes the issue in the deployment issue and fixes the test.

I'll let addshore take a look if/how to incorporate this into his chain of patches for master.

aude added a project: Patch-For-Review.Jul 31 2015, 1:20 AM
aude set Security to None.
aude added a project: Wikidata-Sprint-2015-06-30.Jul 31 2015, 1:30 AM
aude claimed this task.Jul 31 2015, 1:50 AM
aude moved this task from Backlog to Review on the Wikidata-Sprint-2015-06-30 board.
Bene subscribed.Jul 31 2015, 6:09 AM

We should also create integration tests to prevent such issues in future.

gerritbot subscribed.Jul 31 2015, 4:00 PM

Change 228184 merged by jenkins-bot:
Fix ApiXmlFormatTest and raw mode handling in api

https://gerrit.wikimedia.org/r/228184

aude mentioned this in rEWBA62e6fe44a874: Fix ApiXmlFormatTest and raw mode handling in api.Jul 31 2015, 4:00 PM
gerritbot added a comment.Jul 31 2015, 4:32 PM

Change 228300 had a related patch set uploaded (by Aude):
Update Wikidata - fix api xml / raw mode handling

https://gerrit.wikimedia.org/r/228300

gerritbot added a comment.Jul 31 2015, 4:56 PM

Change 228300 merged by jenkins-bot:
Update Wikidata - fix api xml / raw mode handling

https://gerrit.wikimedia.org/r/228300

aude mentioned this in rMW44ade1500c54: Updated mediawiki/core Project: mediawiki/extensions/Wikidata….Jul 31 2015, 4:57 PM
aude mentioned this in rEWDA949fd5143def: Update Wikidata - fix api xml / raw mode handling.Jul 31 2015, 4:59 PM
aude added a comment.Jul 31 2015, 5:13 PM

the bug fix is deployed now. (still needs to be fixed in master though. I think addshore is working to get rid of row mode special handling entirely)

aude removed a project: Patch-For-Review.Jul 31 2015, 5:31 PM
aude moved this task from Review to Doing on the Wikidata-Sprint-2015-06-30 board.
gerritbot added a comment.Aug 3 2015, 3:56 PM

Change 228841 had a related patch set uploaded (by Addshore):
Fix ApiXmlFormatTest and raw mode handling in api

https://gerrit.wikimedia.org/r/228841

gerritbot added a project: Patch-For-Review.Aug 3 2015, 3:56 PM
Addshore added a comment.Aug 3 2015, 4:40 PM

will fix a patch up for master now and then remove the usages afterwards!

gerritbot added a comment.Aug 3 2015, 5:20 PM

Change 228841 merged by jenkins-bot:
Fix ApiXmlFormatTest and raw mode handling in api

https://gerrit.wikimedia.org/r/228841

Diffusion mentioned this in rMEXT9aa82b404fad: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 3 2015, 5:20 PM
Addshore mentioned this in rEWBA18dcb41b6165: Fix ApiXmlFormatTest and raw mode handling in api.Aug 3 2015, 5:20 PM
aude closed this task as Resolved.Aug 3 2015, 7:56 PM
aude removed a project: Patch-For-Review.
aude moved this task from Doing to Done on the Wikidata-Sprint-2015-06-30 board.
Tobi_WMDE_SW edited a custom field.Aug 5 2015, 9:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL