Incorrect CSS rules defining the blocks placement at WM-ES main page
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Platonides
	Nov 25 2013, 10:59 PM

Description

The site http://www.wikimedia.org.es/ is just a MediaWiki install with a custom skin. The main page blocks (Actividades, Participa, Dona, Blog and the slideshow) are achieved with a tag which outputs the needed html.

However, there is a bug in the css, which relies on some element of the custom skin for proper placement. Compare http://www.wikimedia.org.es/wiki/Portada?useskin=wmes (Good: Actividades, Participa & Dona at the left) with http://www.wikimedia.org.es/wiki/Portada?useskin=vector (Wrong: Actividades, Participa & Dona appear on top of the slideshow).

Figure out the wrong rules and provide a patch for fixing the issue, so it works on any skin. Both the html (the php file) and the css can be changed.

Since this extension is not in gerrit, the patch shall be provided on this bug.

Version: unspecified
Severity: normal
Whiteboard: gci2013
URL: http://www.google-melange.com/gci/task/view/google/gci2013/6649325425786880

Details

Reference: bz57563

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:17 AM

• bzimport added projects: MediaWiki-extensions-General, good first task.

• bzimport set Reference to bz57563.

• bzimport added a subscriber: Unknown Object (MLST).

Platonides created this task.Nov 25 2013, 10:59 PM

HomePageWMES.php

Extension file providing the html

Attached:

HomePageWMES.php6 KBDownload

style.css

CSS file. Can also be found at http://www.wikimedia.org.es/w/extensions/HomePageWMES/style.css

Attached:

style.css2 KBDownload

Hi, these are on-wiki issues which have nothing to do with the MediaWiki software or Wikimedia server configuration. Why was this filed in Bugzilla?

[Adding "gci2013" whiteboard entry as explained on https://www.mediawiki.org/wiki/Google_Code-in#Mentors.27_corner and to avoid confusion like in comment 3.]

Platonides: Is there a corresponding task in www.google-melange.com ? What's the URL?

Created attachment 14199
A fix to the bug

Attached:

fix-columns-float.patch260 BDownload

Created attachment 14200
Small enhancement to the second CSS file

Created some enhancement to the http://www.wikimedia.es/w/skins/wmes/style.css?303Y CSS file. Since some CSS properties are now handled via the CSS I've previously posted patch to, it's unnecessary to have them at two places.

Attached:

fix-columns-float-enhance.patch286 BDownload

By the way: the URL of the task is http://www.google-melange.com/gci/task/view/google/gci2013/6649325425786880 :)

The fix is right.
Happy New Year, Mateusz!

Incorrect CSS rules defining the blocks placement at WM-ES main pageClosed, ResolvedPublicActions

Description

Details

Event Timeline

Incorrect CSS rules defining the blocks placement at WM-ES main page
Closed, ResolvedPublic
Actions