Page MenuHomePhabricator

Jenkins should identify voting test failures more prominently
Closed, DeclinedPublic

Description

This is somewhat related to bug 35943. I see this sort of thing regularly:

14:45 <jackmcbarn> why is jenkins-bot failing my commit for stuff i didn't touch?
14:45 <jackmcbarn> https://gerrit.wikimedia.org/r/#/c/97855/
14:46 <ori-l> jackmcbarn: it's the last failure that is causing it to veto
14:46 jackmcbarn looks

The meaning of '(non-voting)' is not very obvious, I think. We ask human reviewers to be explicit in identifying their grounds for -1 patches; I don't see why Jenkins-bot couldn't be held to the same standard :)

IMHO, just exclude non-voting tests from Jenkins's comments. Do people actually look at them?


Version: wmf-deployment
Severity: normal

Details

Reference
bz57627

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM
bzimport set Reference to bz57627.
bzimport added a subscriber: Unknown Object (MLST).

The non-voting jobs are there for information. People do look at them, for example the PHP CodeSniffer ones being run on MediaWiki core. Whenever they are reliably passing, they are made voting.