Page MenuHomePhabricator

Special:AggregateGroups is not compatible with MW 1.20 and 1.21
Closed, ResolvedPublic

Description

Unknown dependency jquery.chosen. Was included in 1.22.x releases onwards. Suggested fix is to bundle our own copy and register it if the module is not present already.

Reported at: https://www.mediawiki.org/wiki/Thread:Extension_talk:Translate/Special:Aggregate_groups_page_not_working/reply


Version: master
Severity: normal

Details

Reference
bz57672

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:25 AM
bzimport set Reference to bz57672.
bzimport added a subscriber: Unknown Object (MLST).

Nice catch. This blocks MLEB 2013.11's compatibility with 1.20 and 1.21.

Sorry, I didn't notice that the translate extension should work with MW 1.21, otherwise I wouldn't have included that. https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle didn't give any other help about that requirement, should have had a look at https://www.mediawiki.org/wiki/Extension:Translate ...

If I should revert my change out, please let me know.

(In reply to comment #3)

If I should revert my change out, please let me know.

No need. We will see if we can implement a solution tomorrow, or exclude the change from the MLEB release until we do have the time to update master.

Change 98072 had a related patch set uploaded by Siebrand:
Revert "Make Special:AggregateGroups using jquery.chosen"

https://gerrit.wikimedia.org/r/98072

Change 98075 had a related patch set uploaded by Nikerabbit:
Bundle jquery.chosen and load if for older MediaWiki

https://gerrit.wikimedia.org/r/98075

Change 98075 merged by jenkins-bot:
Bundle jquery.chosen and load it for older MediaWiki

https://gerrit.wikimedia.org/r/98075

Change 98072 abandoned by Siebrand:
Temporarily revert "Make Special:AggregateGroups using jquery.chosen"

Reason:
Niklas decided to get mad about reduction of features, and just implemented BC in https://gerrit.wikimedia.org/r/#/c/98075/. Yay.

https://gerrit.wikimedia.org/r/98072

(In reply to comment #9)

Reason:
Niklas decided to get mad about reduction of features, and just implemented
BC in https://gerrit.wikimedia.org/r/#/c/98075/. Yay.

Just to make sure this is not being misinterpreted: It was meant as a joke.