Page MenuHomePhabricator

Review mediawiki.ApiRequest.js to ensure that DoesNotExistError logging is useful and informative in all cases.
Closed, ResolvedPublic

Description

We are trying to debug a failure with the way parsoid is set up in the Labs-Vagrant visualeditor role setup
https://wikitech.wikimedia.org/wiki/Talk:Labs-vagrant#Parsoid_errors_using_VisualEditor_role

When the client gets 404 errors, the error in /var/log/upstart/parsoid.log is just

ERROR in localhost:Main_Page
Stack trace: DoesNotExistError: Page Fetch failure for null
worker 25269 died (1), restarting.

but it doesn't say what the error is.
ebernhardson tweaked the second line to actually say what's going wrong by adding error to the output, so the second line becomes

Stack trace: DoesNotExistError: Page Fetch failure for null : Error: Invalid URI "undef/w/api.php?format=json&action=query&meta=siteinfo&siprop=namespaces%7Cnamespacealiases%7Cmagicwords%7Cfunctionhooks%7Cextensiontags%7Cgeneral%7Cinterwikimap%7Clanguages%7Cprotocols"

, and now we can get somewhere :)

Two-line patch on its way


Version: unspecified
Severity: normal

Details

Reference
bz57694

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
bzimport added a project: Parsoid-Web-API.
bzimport set Reference to bz57694.

Change 98038 had a related patch set uploaded by Spage:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/98038

Let us leave this bug open even after this patch is merged. We should review all our response handlers and make sure we are emitting informative log messages based on the error that is returned. Looking at the code, I see that we return early in many handlers.

Change 98038 merged by jenkins-bot:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/98038

I changed the title so we can review that we do have useful logging in all handlers and wanted to keep this open till we have actually reviewed it.

Change 101336 had a related patch set uploaded by GWicke:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/101336

Change 101336 merged by GWicke:
More informative DoesNotExistError logging.

https://gerrit.wikimedia.org/r/101336