Page MenuHomePhabricator

Wikidata: CTRL+click and middle click on search suggestions doesn't open the page in a new tab
Closed, ResolvedPublic

Description

The feature should work as in any Wikipedia.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=3 s=2014-07-01

Details

Reference
bz57709

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:28 AM
bzimport set Reference to bz57709.
bzimport added a subscriber: Unknown Object (MLST).

Helder: Ping what? Do you have question?

This is just very very annoying and was fixed very quickily in every other extension where this kind of problem happened with some of the clickable interface.

How can this be any more difficult than fixing bug 43373 [1] or even bug 56905 [2]?

This feature already works by default in the search suggestion field of other WMF wikis since Change-Id: I87940ca86a2b3776969cbcee8cdf93e3c66b0cd9.

It only fails on Wikidata.

[1] https://gerrit.wikimedia.org/r/#/c/42541/3/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.track.js,unified
[2] https://gerrit.wikimedia.org/r/#/c/94971/1/js/ext.multimediaViewer.js,unified

Wikidata apparently reimplements the feature from scratch, so the fix would also have to be reimplemented from scratch.

(In reply to Bartosz Dziewoński from comment #5)

Wikidata apparently reimplements the feature from scratch, so the fix would
also have to be reimplemented from scratch.

Yeah. We've recently re-written this part. Now it is easier to fix. It is still not an "easy" bug :)

We have a patch now as Thiemo linked above.

Still not working when I go to
https://www.wikidata.org
and type "WP:Test" in the search box and then in the "Containing... WP:Test" suggestion.

(In reply to Helder from comment #8)

Still not working [...] in the "Containing [...]

That's consistent to MediaWiki's core suggester. Sure, that's no reason to not have this feature. But if we do this we should fix core's suggester too to be consistent again.

It works fine on core[1] and just fails on Wikidata. But yes, the behavior should be consistent.

[1] I just tested it using Firefox 30.0 on
https://en.wikipedia.org/wiki/Special:Watchlist
by typing "test" and CTRL+clicking the suggestion I got
https://en.wikipedia.org/w/index.php?search=test&title=Special%3ASearch&fulltext=1
in a new tab. On wikidata the page was reloaded instead.

Marking this as fixed. We have bug 66432 for the remaining issue.