Page MenuHomePhabricator

Sort out relationship between TimeFormatter and TimeIsoFormatter
Open, MediumPublic

Description

There should be two kinds of values for "points in time" (with a precision, time zone, calendar, etc) and simple "timestamps" (just an ISO date string). There should be formatters for each, where the formatter for the complex time value uses a formatter for timestamps as a parameter.


Version: unspecified
Severity: minor
Whiteboard: cleanup

Details

Reference
bz57743

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:30 AM
bzimport added a project: DataValues.
bzimport set Reference to bz57743.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

We more or less constantly worked on this over the past year.

In https://github.com/DataValues/Time/pull/49 I'm trying to make TimeFormatter an actual TimeValue formatter that does as much as possible with no knowledge about MediaWiki and languages at all.

The class that's currently called MwTimeIsoFormatter still needs to be renamed and refactored. Is this what this ticket is about? Otherwise I suggest to close this. Most important: A formatter that gets a timestamp string and nothing else does not make sense to me. Having multiple formatters for TimeValues does make sense.