| liangent | |
| Nov 29 2013, 6:23 PM |
| F17691: 20141130100406000000-16577-WbLinkTitlesLocal.log | |
| Dec 1 2014, 10:34 AM |
| F17690: 20141130100338000000-15961-WbLinkTitlesLocal.log | |
| Dec 1 2014, 10:34 AM |
| F17692: 20141130100414000000-16743-WbLinkTitlesLocal.log | |
| Dec 1 2014, 10:34 AM |
| F17693: 20141130100503000000-17737-WbLinkTitlesLocal.log | |
| Dec 1 2014, 10:34 AM |
action=wbeditentity&clear=true call with baserevid set should express that "I have looked at revision XXX and if now it's still like what I've seen, clear everything and use my data to replace the existing one". However, it's not the case in reality and even caused claims to be duplicated (it seems 'clear' is not performed): https://www.wikidata.org/w/index.php?title=Q1805224&diff=89778591&oldid=89777433
Version: unspecified
Severity: normal
Repro:
token=XXX&data=%7B%7D&new=item
{
"entity": {
"labels": [],
"descriptions": [],
"aliases": [],
"sitelinks": [],
"claims": [],
"id": "Q245",
"type": "item",
"lastrevid": 2588
},
"success": 1}
id=Q245&token=XXX&data=%7B%22labels%22%3A%5B%7B%22language%22%3A%22en%22%2C%22value%22%3A%22Foo%22%7D%5D%2C%22claims%22%3A%7B%22P55%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P55%22%2C%22datavalue%22%3A%20%7B%22value%22%3A%20%22abc%22%2C%22type%22%3A%20%22string%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D%7D
{
"entity": {
"labels": {
"en": {
"language": "en",
"value": "Foo"
}
},
"descriptions": [],
"aliases": [],
"sitelinks": [],
"claims": {
"P55": [
{
"id": "Q245$0CF9E5D0-31CD-4019-86A8-CF5AAA1CD596",
"mainsnak": {
"snaktype": "value",
"property": "P55",
"datavalue": {
"value": "abc",
"type": "string"
}
},
"type": "statement",
"rank": "normal"
}
]
},
"id": "Q245",
"type": "item",
"lastrevid": 2589
},
"success": 1}
id=Q245&baserevid=2589&token=XXX&data=%7B%22labels%22%3A%5B%7B%22language%22%3A%22de%22%2C%22value%22%3A%22Bar%22%7D%5D%2C%22claims%22%3A%7B%22P55%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P55%22%2C%22datavalue%22%3A%20%7B%22value%22%3A%20%22def%22%2C%22type%22%3A%20%22string%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D%7D&clear=
{
"entity": {
"labels": {
"de": {
"language": "de",
"value": "Bar"
}
},
"descriptions": [],
"aliases": [],
"sitelinks": [],
"claims": {
"P55": [
{
"id": "Q245$8424C010-5151-44B3-B00C-6F2E6EEE436B",
"mainsnak": {
"snaktype": "value",
"property": "P55",
"datavalue": {
"value": "def",
"type": "string"
}
},
"type": "statement",
"rank": "normal"
}
]
},
"id": "Q245",
"type": "item",
"lastrevid": 2590
},
"success": 1}
id=Q245&baserevid=2589&token=XXX&data=%7B%22labels%22%3A%5B%7B%22language%22%3A%22nl%22%2C%22value%22%3A%22Bar%22%7D%5D%2C%22claims%22%3A%7B%22P55%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P55%22%2C%22datavalue%22%3A%20%7B%22value%22%3A%20%22qwerty%22%2C%22type%22%3A%20%22string%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D%7D&clear=
{
"entity": {
"labels": {
"nl": {
"language": "nl",
"value": "Bar"
}
},
"descriptions": [],
"aliases": [],
"sitelinks": [],
"claims": {
"P55": [
{
"id": "Q245$31144320-3601-4B00-B733-7F1DC6245C65",
"mainsnak": {
"snaktype": "value",
"property": "P55",
"datavalue": {
"value": "qwerty",
"type": "string"
}
},
"type": "statement",
"rank": "normal"
}
]
},
"id": "Q245",
"type": "item",
"lastrevid": 2591
},
"warnings": {
"messages": {
"0": {
"name": "wikibase-self-conflict-patched",
"type": "warning"
},
"html": {
"*": "<p>Your edit was patched into the latest version, overriding some of your own intermediate changes.\n</p>"
}
}
},
"success": 1}
The warning? I guess an action=wbeditentity&clear=true call can hardly be interpretted as a "patch".
Change 98795 had a related patch set uploaded by Legoktm:
Die if wbeditentity tries to clear from old revid
Change 98795 merged by jenkins-bot:
Die if wbeditentity tries to clear from old revid
I logged the attached data about https://www.wikidata.org/w/index.php?title=Q874074&action=history . It appears the behavior has regressed.
AFAIk this is still fixed...
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/api/EditEntity.php#L172
no idea why this issue is still open