Page MenuHomePhabricator

git-deploy doesn't sync submodules
Closed, ResolvedPublic

Description

The integration/jenkins.git project is available for deployment on tin.eqiad.wmnet under /srv/deployment/integration/slave-scripts

That repositories has some submodules, to deploy it I went with:

git deploy start
git submodule update --init
git deploy sync

All the target have received a copy of the main git repository but the submodules ARE NOT THERE.

Expected behavior: git deploy sync should replicate the repository on the deployment machine in the exact same state.


Version: wmf-deployment
Severity: normal

Details

Reference
bz57880

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:39 AM
bzimport added a project: Deployments.
bzimport set Reference to bz57880.
bzimport added a subscriber: Unknown Object (MLST).

Change 98778 had a related patch set uploaded by Hashar:
deployment: integration/slave-scripts has submodules

https://gerrit.wikimedia.org/r/98778

Change 98778 merged by Ryan Lane:
deployment: integration/slave-scripts has submodules

https://gerrit.wikimedia.org/r/98778

hashar: Does this require more work (if so what) or has merging the patch in comment 2 fixed this?

I think Ryan hint to add:

'checkout_submodules' => true,

Fix the issue. I was assuming git deploy would handle submodules by default.