Page MenuHomePhabricator
Create Task
Maniphest T59883

Declaration of SpecialSearchTranslations::setHeaders() should be compatible with SpecialPage::setHeaders
Closed, ResolvedPublic
Actions

Description

[02-Dec-2013 20:23:31 UTC] PHP Strict Standards: Declaration of SpecialSearchTranslations::setHeaders() should be compatible with SpecialPage::setHeaders($robotPolicy = 'noindex,no...') in /www/translatewiki.net/w/includes/AutoLoader.php on line 1215

Version: master
Severity: normal

Details

Reference
bz57883

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:39 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz57883.
• bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Dec 2 2013, 8:43 PM
siebrand added a comment.Dec 2 2013, 9:17 PM

This is caused by gerrit 98255.

gerritbot added a comment.Dec 2 2013, 9:20 PM

Change 98692 had a related patch set uploaded by Parent5446:
Revert "Add $robotPolicy parameter to SpecialPage::setHeaders()"

https://gerrit.wikimedia.org/r/98692

gerritbot added a comment.Dec 2 2013, 9:27 PM

Change 98692 merged by jenkins-bot:
Revert "Add $robotPolicy parameter to SpecialPage::setHeaders()"

https://gerrit.wikimedia.org/r/98692

siebrand added a comment.Dec 2 2013, 9:47 PM

Fixed by reverting the root cause.

Bawolff added a comment.Dec 2 2013, 9:54 PM

Sorry, I forgot that php would spew warnings if anyone had overridden that method. (I've always thought that was stupid when the formal parameters had a default value)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL