Page MenuHomePhabricator

Old topic on ee-flow Sandbox page causes fatal error
Closed, ResolvedPublic

Description

Screenshot of error message

At http://ee-flow.wmflabs.org/wiki/Sandbox when I scroll all the way to the bottom, I get this error: (attachment 1) "An error occurred while contacting the server."

Left-clicking "Older topics" does nothing.

If I middle-click "Older topics" to open it in a new tab, I get this bizarre mess: (attachment 2)


Version: unspecified
Severity: normal

Attached:

Screenshot_from_2013-12-02_14:22:53.png (557×858 px, 61 KB)

Details

Reference
bz57897

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:41 AM
bzimport set Reference to bz57897.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 13963
screenshot of middle-clicked "Older topics"

Attached:

Screenshot_from_2013-12-02_14:38:21.png (1×1 px, 88 KB)

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/563, but people from the community are welcome to contribute here and in Gerrit.

FYI

  • The error box from "Older topics" is when the infinite scroll makes an API request for more stuff from the server within the current page.
  • The garbled contents from middle-clicking the Older topics link is when rendering blows up and MediaWiki sends an incomplete initial page to the browser without CSS, JS, and navigation elements.

After fiddling around, I found this URL reliably shows the error message after one pagination:
http://ee-flow.wmflabs.org/wiki/Sandbox?&topic_list[offset-id]=050664a62a00b62ef835fa163e68c4ac&topic_list[offset-dir]=fwd&topic_list[limit]=10

The last API request fails with the 500 error:

"GET /w/api.php?action=query&format=json&list=flow&flowpage=Sandbox&flowworkflow=0503c3d2e3d2ad56ca39fa163e68c4ac&flowparams=%7B%22topic_list%22%3A%7B%22offset-dir%22%3A%22fwd%22%2C%22offset-id%22%3A%220505c769ba78b62ef835fa163e68c4ac%22%2C%22limit%22%3A10%2C%22render%22%3Atrue%7D%7D HTTP/1.1" 500 998 "http://ee-flow.wmflabs.org/wiki/Sandbox?&topic_list[offset-id]=050664a62a00b62ef835fa163e68c4ac&topic_list[offset-dir]=fwd&topic_list[limit]=10

I figured out it's the topic "Moats", because viewing that same flowworkflow UUID,
http://ee-flow.wmflabs.org/w/index.php?title=Sandbox&workflow=0505c32dd7fcb62ef835fa163e68c4ac,
reliably blows up with a bunch of errors in apache2/error.log (below).

These posts are so old they might be stored as wikitext instead of HTML and have other incompatibilities.

error.log contents:

[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Warning: array_filter() expects parameter 1 to be array, null given in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 294
^ repeated 10 times, then
[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Warning: array_fill(): Number of elements must be positive in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 244
[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Warning: array_shift() expects parameter 1 to be array, null given in /srv/mediawiki/extensions/Flow/includes/Templating.php on line 232
[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Warning: array_pop() expects parameter 1 to be array, null given in /srv/mediawiki/extensions/Flow/includes/Templating.php on line 233
[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Warning: array_pop() expects parameter 1 to be array, null given in /srv/mediawiki/extensions/Flow/includes/Templating.php on line 234

[Wed Dec 11 05:28:09 2013] [error] [client 216.38.130.164] PHP Catchable fatal error: Argument 1 passed to Flow\\Model\\PostRevision::descendRecursive() must be an array, boolean given, called in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 240 and defined in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 262

The old problematic "Moats" topic http://ee-flow.wmflabs.org/w/index.php?title=Sandbox&workflow=0505c32dd7fcb62ef835fa163e68c4ac is still displaying badly with error:

[Sat Jan 04 01:24:46 2014] [error] [client 216.38.130.164] PHP Catchable fatal error: Argument 1 passed to Flow\\Model\\PostRevision::descendRecursive() must be an array, boolean given, called in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 204 and defined in /srv/mediawiki/extensions/Flow/includes/Model/PostRevision.php on line 226

I'm having trouble paginating Talk:Sandbox to it, it's not showing up even when I use a load topics around "Fri, 04 Oct 2013 00:49:47 GMT"