Page MenuHomePhabricator

Users can create empty /UserProfileIntro pages
Closed, ResolvedPublic

Details

Reference
bz57931

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:13 AM
bzimport set Reference to bz57931.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1474

MariaDB [enwiki_p]> select page_title from page where page_namespace=2 and page_title like "%/UserProfileIntro" and page_len=0;
+-------------------------------------------------+

page_title

+-------------------------------------------------+

Asep_suryawan/UserProfileIntro
Choi1997/UserProfileIntro
Dep_trai.la.anh/UserProfileIntro
Adisadis/UserProfileIntro
Blueboxkid/UserProfileIntro
ADLR1012/UserProfileIntro
Lightsculptsa/UserProfileIntro
Karan_Malhotra_Wolf_Production/UserProfileIntro

+-------------------------------------------------+
8 rows in set (0.44 sec)

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1475

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1476

There is no prohibition against creating empty pages via the API. I guess if we want to avoid it in this case, we'll have to pass the existence of the page to the client and allow the JS to skip the save step in that case.

OK, I spoke to soon. We should not be able to create new empty pages through the API. I'm not sure what's going on here.

In my local instance, when I try to save an empty UserProfile, I get the following error from the API: "Creating new, empty pages is not allowed". On en.wiki, however, it works fine.

Submitted a patch set in gerrit, but for some reason it hasn't been added here:
https://gerrit.wikimedia.org/r/#/c/99020/

Change 99020 had a related patch set uploaded by Legoktm:
Don't try to save if the form is empty and the page doesn't exist.

https://gerrit.wikimedia.org/r/99020

Change 99020 merged by jenkins-bot:
Don't create empty user descriptions for User Profile

https://gerrit.wikimedia.org/r/99020