Page MenuHomePhabricator

Flow: Implement limitations based on characters instead of bytes
Closed, ResolvedPublic

Description

Gerrit 98737 limits topic titles to 260 bytes.

We have languages that have 3 bytes per character. That means these languages can have topics up to ~86 characters long, where most Western European languages will be able to have topics up to 260 characters long. That's a big difference in functional specification, just because the specification uses a unit of measure that users have little understanding of.


Version: master
Severity: normal

Details

Reference
bz57933

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:14 AM
bzimport set Reference to bz57933.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/568, but people from the community are welcome to contribute here and in Gerrit.

(In reply to comment #2)

Did this fix problems like bug 4714 and bug 4715

No, those are in core, this is just for the Flow extension. By the way, you can just enter "bug NNNN" as I did and Bugzilla will auto-link it.

Change 110141 had a related patch set uploaded by EBernhardson:
Perform topic length validation with mb_strlen

https://gerrit.wikimedia.org/r/110141

Change 110141 merged by jenkins-bot:
Perform topic length validation with mb_strlen

https://gerrit.wikimedia.org/r/110141