Page MenuHomePhabricator

VisualEditor: [Regression] "Switch to source editing" dies
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Click on Switch to source editing from the down menu for an article on betalabs

Observed Result:
Nothing happens.It does not switch to source editing from VE


Version: unspecified
Severity: critical

Details

Reference
bz57947

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:14 AM
bzimport set Reference to bz57947.

Test Environment: production
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Example Pagehttp://en.wikipedia.beta.wmflabs.org/wiki/Groel?veaction=edit

Sorry Test Environment should be betalabs in my previous comment.

Bug 57926 is now fixed - does this still occur?

Change 98989 had a related patch set uploaded by Jforrester:
Fix naked request for save dialog's summary in save

https://gerrit.wikimedia.org/r/98989

Change 98989 merged by jenkins-bot:
Fix naked request for save dialog's summary in save

https://gerrit.wikimedia.org/r/98989

jhall wrote:

Seeing something slightly odd after this fix was deployed to Betalabs - not sure this is Bad Thing, so not re-opening the bug at this point…

There are 2 pathways to switch from VE to wikitext, and they now navigate the user to different URLs (this didn't happen prior to the bug fix).

If you start in VE editing mode, and use the "Edit Source" tab to switch to wikitext, you end up at:

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Oldjoe&action=edit

On other hand, if you start in VE editing mode and select "Switch to source editing" from the Page Settings drop-down, you end up at:

http://en.wikipedia.beta.wmflabs.org/wiki/User:Oldjoe?action=submit

Is this the intended behavior?

(In reply to comment #9)

Seeing something slightly odd after this fix was deployed to Betalabs - not
sure this is Bad Thing, so not re-opening the bug at this point…

There are 2 pathways to switch from VE to wikitext, and they now navigate the
user to different URLs (this didn't happen prior to the bug fix).

If you start in VE editing mode, and use the "Edit Source" tab to switch to
wikitext, you end up at:

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:
Oldjoe&action=edit

On other hand, if you start in VE editing mode and select "Switch to source
editing" from the Page Settings drop-down, you end up at:

http://en.wikipedia.beta.wmflabs.org/wiki/User:Oldjoe?action=submit

Is this the intended behavior?

The change to the primary entry point isn't explicitly intended, but I don't think it's the end of the world to push people towards the canonical (and simpler) URLs.