CirrusSearchSearcher::prefixSearch() with CirrusSearchTitleResultsType can return either a SearchResultSet subclass or a Status object. CirrusSearch::prefixSearch() puts this Status object directly into the &$results variable of the PrefixSearchBackend hook, without any validation, which is presumably the cause of the PHP warnings noted by Sam Reed at Id773c23747c.

The recommended pattern for using Status objects is to return a Status unconditionally, with Status::newGood($value) used to indicate success. This forces the caller to implement error handling, and thus avoids PHP errors of this kind.

Version: unspecified
Severity: major