Page MenuHomePhabricator

API unit tests generate output in the middle of the phpunit progress indicator
Closed, ResolvedPublic

Description

Configuration read from /usr/home/saper/test/mytest/tests/phpunit/suite.xml

............................................................. 61 / 7428 ( 0%)
.................EEEEEEEE.................................... 122 / 7428 ( 1%)
............................................................. 183 / 7428 ( 2%)
............................................................. 244 / 7428 ( 3%)
............................................................. 305 / 7428 ( 4%)
............................................................. 366 / 7428 ( 4%)
............................................................. 427 / 7428 ( 5%)
............................................................. 488 / 7428 ( 6%)
............................................................. 549 / 7428 ( 7%)
............................................................. 610 / 7428 ( 8%)
............................................................. 671 / 7428 ( 9%)
............................................................. 732 / 7428 ( 9%)
............................................................. 793 / 7428 ( 10%)
............................................................. 854 / 7428 ( 11%)
............................................................. 915 / 7428 ( 12%)
............................................................. 976 / 7428 ( 13%)
............................................................. 1037 / 7428 ( 13%)
............................................................. 1098 / 7428 ( 14%)
............................................................. 1159 / 7428 ( 15%)
............................................................. 1220 / 7428 ( 16%)
............................................................. 1281 / 7428 ( 17%)
............................................................. 1342 / 7428 ( 18%)
............................................................. 1403 / 7428 ( 18%)
............................................................. 1464 / 7428 ( 19%)
............................................................. 1525 / 7428 ( 20%)
............................................................. 1586 / 7428 ( 21%)
............................................................. 1647 / 7428 ( 22%)
............................................................. 1708 / 7428 ( 22%)
...............E............................................. 1769 / 7428 ( 23%)
............................................................. 1830 / 7428 ( 24%)
............................................................. 1891 / 7428 ( 25%)
............................................................. 1952 / 7428 ( 26%)
............................................................. 2013 / 7428 ( 27%)
............................................................. 2074 / 7428 ( 27%)
......................EE..FF......E.......................... 2135 / 7428 ( 28%)
...........E................................................. 2196 / 7428 ( 29%)
............................................................. 2257 / 7428 ( 30%)
.......................................F
Request: generator=links&titles=AQBT-Links&action=query

Expected:
Array
(

[query] => Array
    (
        [pages] => Array
            (
                [1] => Array
                    (
                        [pageid] => 1
                        [ns] => 0
                        [title] => AQBT-All
                    )

                [2] => Array
                    (
                        [pageid] => 2
                        [ns] => 0
                        [title] => AQBT-Categories
                    )

                [4] => Array
                    (
                        [pageid] => 4
                        [ns] => 0
                        [title] => AQBT-Templates
                    )

            )

    )

)

Result:
Array
(

[query] => Array
    (
        [pages] => Array
            (
                [109] => Array
                    (
                        [pageid] => 109
                        [ns] => 0
                        [title] => AQBT-Categories
                    )

                [108] => Array
                    (
                        [pageid] => 108
                        [ns] => 0
                        [title] => AQBT-All
                    )

                [111] => Array
                    (
                        [pageid] => 111
                        [ns] => 0
                        [title] => AQBT-Templates
                    )

            )

    )

)
..................... 2318 / 7428 ( 31%)


Version: unspecified
Severity: trivial

Details

Reference
bz57974

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:16 AM
bzimport set Reference to bz57974.
bzimport added a subscriber: Unknown Object (MLST).

Actually all ApiQuerySqliteBugTest is having this problem, too.

What's wrong with using print_r for printing output? What do you think should be used instead?

Oh, I think I see the problem. It's not print_r, it's that the output (some of which is print_r and some plain print statements) is being dumped in the middle of the progress indication rather than being accumulated into the test result.

Change 99156 had a related patch set uploaded by Anomie:
Improve ApiQueryTestBase::assertResult

https://gerrit.wikimedia.org/r/99156

Change 99156 merged by jenkins-bot:
Improve ApiQueryTestBase::assertResult

https://gerrit.wikimedia.org/r/99156