Page MenuHomePhabricator

property parser function fails to render values
Closed, ResolvedPublic

Description

property parser function is failing to render values on wikipedia and wikivoyage:

Failed to render property signature: Property not found for label 'en' and language 'signature'

this happens for lookup of property by label.

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#signature_property_problem

i cannot reproduce on my test wikis with mw1.23-wmf5 version of everything, nor on test2.wikipedia which has wmf6


Version: master
Severity: normal

Details

Reference
bz58099

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:25 AM
bzimport set Reference to bz58099.
bzimport added a subscriber: Unknown Object (MLST).

Change 99658 had a related patch set uploaded by Aude:
Update Wikibase, for issue with parser function

https://gerrit.wikimedia.org/r/99658

also quite sure i never saw it on test.wikidata in the past 2 weeks (before deploying to wikivoyage)

Change 99658 merged by Reedy:
Update Wikibase, for issue with parser function

https://gerrit.wikimedia.org/r/99658

Change 99681 had a related patch set uploaded by Aude:
disable display of wikibasse parser function errors

https://gerrit.wikimedia.org/r/99681

the cache was not properly invalidating for TermPropertyLabelResolver

doing this on one of the clients forced recache and resolved the issue for the clients

$store = \Wikibase\Client\WikibaseClient::getDefaultInstance()->getStore();
$labelResolver = $store->getPropertyLabelResolver();
$id = $labelResolver->getPropertyIdsForLabels( array( 'signature' ), 'recache' );

we need to ensure this cache is using a cache key that changes with each deployment.

Change 99681 abandoned by Aude:
Disable display of wikibase parser function errors

Reason:
shall resubmit, if/when needed

https://gerrit.wikimedia.org/r/99681