| • bzimport | |
| Dec 6 2013, 3:33 PM |
| F12307: 48x-Community.ico | |
| Nov 22 2014, 2:26 AM |
Author: vladjohn2013
Description:
Create a favicon including 16x16, 32x32, and 48x48 versions of [URL of the high-resolution logo]. Substitute community.ico at operations/mediawiki-config/docroot/bits/favicon with the new version.
Version: wmf-deployment
Severity: enhancement
URL: http://www.google-melange.com/gci/task/view/google/gci2013/5805971553124352
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T47036 Update favicons to provide high res variant | |||
| Resolved | None | T60101 Update favicon community.ico |
vladjohn2013 wrote:
A little problem, the .ico file on the favicom seems to be corrupted. I can not open it.
I cannot open it either. I guess the ico refers to
https://commons.wikimedia.org/wiki/File:Wikimedia_Community_Logo.svg ?
I have no problems opening the file, but yes, it can be created anew from the SVG version of the community logo (or an exported PNG, whichever you prefer) that Quim linked in comment 2.
Vlad John reported problems installing git-review, see the GCI task for details. I haven't used gerrit-review in Windows, neither Gerrit without gerrit-review.
Another option that comes to mind is to submit the patch via https://github.com/wikimedia/operations-mediawiki-config
Any ideas? Committing the patch (as opposed to simply attach the file here is indeed part of the task (since GCI is about learning, and code review is an interesting skill to learn).
(In reply to comment #6)
Vlad John reported problems installing git-review, see the GCI task for
details. I haven't used gerrit-review in Windows, neither Gerrit without
gerrit-review.
I haven't used Windows in a while, so can't comment on that, but it's possible to submit commits to Gerrit without git-review using https://www.mediawiki.org/wiki/Gerrit/Alternatives_to_git-review
Another option that comes to mind is to submit the patch via
https://github.com/wikimedia/operations-mediawiki-config
YuviPanda's SuchABot isn't enabled on this repo, so you'd have to submit all Github pull requests by hand, which is a terrible terrible "solution".
vladjohn2013 wrote:
I tried to upload the patch using this site: tools.wmflabs.org/gerrit-patch-uploader/ , but got this error:
Upload failed
Reason: Patch failed (is your patch in unified diff format, and does it patch apply cleanly to master?) (check log above for details)
How should I create the patch file, and in what format? (I tried both an .ico file and a .diff file)
Hi Vlad, as commented in the GCI task already:
The error message tells you that you need to submit a "patch in unified diff format" that can be applied "cleanly to master".
Please detail at the bug report the command line instructions you are using to generate the diff file and the replies you are getting for each step. This way we can tell you whether you are doing something wrong.
vladjohn2013 wrote:
I am using a program for windows called UnxUtils...
The command i write looks like this:
diff -u oldfile newfile > patchfile
But it says diff:command not found.
I also tried to use WinMerge, where I opened the .ico file from the site, and the .ico file I created, and then in the Tools menu, I used Create patch, but it said I coukd not create a patch from the binarry.
Please us git. GCI is about learning. If you want to be a developer you must learn git. :)