Page MenuHomePhabricator
Create Task
Maniphest T60107

Multimedia Viewer: Keyboard shortcut to activate MV active inside VisualEditor
Closed, ResolvedPublic
Actions

Description

When ve-activated class is set on the body, it would be lovely to deactivate this feature as it's rather irritating. Think it's Shift+cursor or Ctrl+Shift+cursor or something similar?

Version: master
Severity: normal

Details

Reference
bz58107

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:26 AM
• bzimport added a project: MediaViewer.
• bzimport set Reference to bz58107.
Jdforrester-WMF created this task.Dec 6 2013, 6:57 PM
MarkTraceur added a comment.Dec 6 2013, 7:00 PM

This may be because we don't clear keydown listener events on closing the viewer. Patch incomiiiiing

gerritbot added a comment.Dec 6 2013, 8:16 PM

Change 99722 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722

gerritbot added a comment.Dec 10 2013, 1:41 AM

Change 99722 merged by jenkins-bot:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722

MarkTraceur added a comment.Dec 10 2013, 1:41 AM

Bam. Done. Thanks.

gerritbot added a comment.Dec 10 2013, 7:16 PM

Change 100611 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611

gerritbot added a comment.Dec 11 2013, 12:06 AM

Change 100611 merged by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611

MarkTraceur added a comment.Dec 11 2013, 12:14 AM

We backported this fix to 1.23wmf6, so mediawiki.org and all sister sites should be fixed now.

• Gilles added a project: Multimedia.Dec 4 2014, 9:30 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL