Page MenuHomePhabricator

Rewrite Template:Interval in Lua
Closed, ResolvedPublic

Description

According to https://en.wikipedia.org/wiki/Wikipedia:Lua/To_do [[w:Template:Interval]] must be rewritten in Lua.

This is a bug report created to follow the progress. A related Google Code-in task will be created soon.


Version: wmf-deployment
Severity: enhancement
Whiteboard: gci2013
URL: http://www.google-melange.com/gci/task/view/google/gci2013/5242463253954560

Details

Reference
bz58130

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:28 AM
bzimport set Reference to bz58130.

Okay, sandbox module created at https://en.wikipedia.org/wiki/Module:Sandbox/Theopolisme

Testcases are at https://en.wikipedia.org/wiki/Template:Interval/testcases (under "Sandbox template").

Unsure as to next steps -- should I post something at [[w:WT:Lua]] to solicit reviewers? Move it to Module:Interval? Prod at some of my IRC friends? ;) Or is there a different procedure I should follow?

Bravo!

This is the first Lua template related GCI task, and we are polishing the process as we go.

Templates discussion and revision happen mostly in wiki pages, not in the Bugzilla-Gerrit tandem that we use in other coding tasks.

Your template looks good to (inexperienced) me, and your test results are correct. Therefore, as soon as you share your work at https://en.wikipedia.org/wiki/Wikipedia:Lua/To_do where Template:Interval we can close this task.

As we have done with other GCI tasks, you are encouraged to follow possible feedback, this time coming via wiki pages. If your module is considered good, you might be asked to update the current template based on wikitext, and the /doc subpage if there is anything to do there.

PS: I'm also CCing Brad, my usual contact for anything Lua, just in case he wants to review your template.

I've moved the code to [[w:Module:Interval]] and commented at (and watchlisted) the to-do page.