Error messages should be more informative
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	CristianCantoro
	Dec 9 2013, 2:17 PM

Description

Random user names for the test of Wikimetrics (taken from it.wikisource 10th anniversary contest participants)

Step to reproduce:

create a new cohort
choose a name (e.g. "it_wikisource_test_2")
fill in a description
choose a default project (e.g. "itwikisource")
upload file "it_ws_contest_participants.csv" attached
Validate as "User names"
Hit "Upload CSV"

You will get "Error! Server error while processing your upload".

In this case some names should be quoted and following the same procedure while uploading the file named "it_ws_contest_participants_quoted.csv" works.

The example currently used seems to stress the fact that quoting is not necessary (cfr. User Names can even contain commas, but these need a project at the end,en).

A more descriptive error message could help, also a couple of words about quoting CSV files would not hurt (also note that spreadsheet softwares like LibreOffice Calc can automatically quote values when exporting to CSV).

Version: unspecified
Severity: normal

Attached:

it_ws_contest_participants.csv1 KBDownload

Details

Reference: bz58208

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:33 AM

• bzimport added a project: Analytics-Wikimetrics.

• bzimport set Reference to bz58208.

• bzimport added a subscriber: Unknown Object (MLST).

CristianCantoro created this task.Dec 9 2013, 2:17 PM

Created attachment 14031
Same user names as in the test case but quoted, this file works.

Attached:

it_ws_contest_participants_quoted.csv1 KBDownload

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/analytics/cards/1303

Thanks for the bug report Cristian. I've tried to improve name handling, and indeed I don't think the lack of quotes is directly causing this issue. But I'll dig more and see what I can find.

sumanah wrote:

Hmm. I tried the reproduction steps in comment #0 on metrics.wmflabs.org and got:

"Validated 138 of 138 cohort members. 134 are valid, 4 are invalid."

"4 are invalid" links to https://metrics.wmflabs.org/cohorts/detail/invalid-users/609 which tells me:

{

"invalid_wikiusers": [
    {
        "mediawiki_username": "Eusebia", 
        "reason_invalid": "invalid user_name: Eusebia"
    }, 
    {
        "mediawiki_username": "Sanna", 
        "reason_invalid": "invalid user_name: Sanna"
    }, 
    {
        "mediawiki_username": "Francescaesposo", 
        "reason_invalid": "invalid user_name: Francescaesposo"
    }, 
    {
        "mediawiki_username": "Solario60", 
        "reason_invalid": "invalid user_name: Solario60"
    }
]

}

That could be a lot nicer to look at and somewhat more informative. Dan, what do you think of this idea? I could knock together a template that would display a list of those invalid wiki usernames (or user IDs) and state what "invalid" means in this context.

(In reply to comment #4)

Hmm. I tried the reproduction steps in comment #0 on metrics.wmflabs.org and
got:

"Validated 138 of 138 cohort members. 134 are valid, 4 are invalid."

"4 are invalid" links to
https://metrics.wmflabs.org/cohorts/detail/invalid-users/609 which tells me:

{
"invalid_wikiusers": [
    {
        "mediawiki_username": "Eusebia", 
        "reason_invalid": "invalid user_name: Eusebia"
    }, 
    {
        "mediawiki_username": "Sanna", 
        "reason_invalid": "invalid user_name: Sanna"
    }, 
    {
        "mediawiki_username": "Francescaesposo", 
        "reason_invalid": "invalid user_name: Francescaesposo"
    }, 
    {
        "mediawiki_username": "Solario60", 
        "reason_invalid": "invalid user_name: Solario60"
    }
]
}

That could be a lot nicer to look at and somewhat more informative. Dan, what
do you think of this idea? I could knock together a template that would
display
a list of those invalid wiki usernames (or user IDs) and state what "invalid"
means in this context.

It seems a lot better to me, thank you.

Cristian

Cool! I think Sumana had some plans to add a new endpoint here that showed these invalid users as an html page. But I'll leave that for a separate effort. I'm glad the invalid users link works for you, closing the issue for now.

	F12529: it_ws_contest_participants_quoted.csv
	Nov 22 2014, 2:33 AM

Error messages should be more informativeClosed, ResolvedPublicActions

Description

Details

Event Timeline

Error messages should be more informative
Closed, ResolvedPublic
Actions