Page MenuHomePhabricator

OfflineContentGenerator npm tests leak test files
Closed, ResolvedPublic

Description

The integration-slave01 labs instance is running npm tests for the Collection offline content generators:

mwext-Collection-OfflineContentGenerator-bundler-npmtest
mwext-Collection-OfflineContentGenerator-latex_renderer-npmtest
mwext-Collection-OfflineContentGenerator-npmtest

The slave has been brought offline because /tmp ended up being filled. Looking at it I had files such as mw-latexer* and mw-ocg-latexer*.

They should be made temporary files or even better mocked in the unit tests :-)

Details

Reference
bz58216

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:34 AM
bzimport added a project: Collection.
bzimport set Reference to bz58216.
bzimport added a subscriber: Unknown Object (MLST).

It would probably self fix with Bug 68563 - Jenkins: point TMP/TEMP to workspace and delete it after build completion. Added it as a dependency.

Krinkle renamed this task from Collection npm tests leak test files to OfflineContentGenerator npm tests leak test files.Dec 21 2014, 4:18 AM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).

T70563 has been resolved and made it work for mw-builds. We can do the same for npm.

Will need a TMPDIR added to npm-set-env, and a new teardown.

hashar claimed this task.

I had filled that tasks because the tests filled up the Jenkins slaves disk. Nowadays the OfflineContentGenerator tests jobs are run on disposables instances, thus they can leak whatever they want, it is not going to pollute the next build.

Hence fixed for the CI case, might still be an issue in the code but it is not much of a concern imho.