Page MenuHomePhabricator

Tidy up (and perhaps kill) abusefilter.php Wikimedia configuration file
Closed, DeclinedPublic

Description

https://noc.wikimedia.org/conf/abusefilter.php.txt

AbuseFilter went from being per-wiki to being a global (Wikimedia-wide) MediaWiki extension. I think its configuration can be simplified and tidied up.

Low-hanging fruit might be consolidating $wgAbuseFilterNotifications and finding other ways to reduce the need for per-wiki variance in the database case switch.

It also might make sense to evaluate why this particular extension's configuration is still split out to a separate file. It may make sense to put it back with the rest of the extension configuration (i.e., CommonSettings.php or InitialiseSettings.php). That'll require some research and trade-off analysis.


Version: wmf-deployment
Severity: trivial

Details

Reference
bz58247

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:36 AM
bzimport set Reference to bz58247.
bzimport added a subscriber: Unknown Object (MLST).

aravikn wrote:

Could someone assign this to me?

Aravind: Just feel free to work on this by putting a patch into Gerrit.

Doesn't seem like people actually want this... https://gerrit.wikimedia.org/r/114656 ... wontfix?

(In reply to Marius Hoch from comment #3)

Doesn't seem like people actually want this...
https://gerrit.wikimedia.org/r/114656 ... wontfix?

That's not what I said. I "objected" to the removal of 2 lines out of 26 you were removing. There is surely a lot of unnecessary code duplication. For instance, many wikis have an identical, while non-default, configuration: we could have 2-3 "models" and then have one single line for a wiki to adopt one + adaptations. Just to throw one idea towards the goal mentioned by MZ.

Change 114656 had a related patch set uploaded by Hoo man:
Simplify the AbuseFilter configuration a little

https://gerrit.wikimedia.org/r/114656

Change 114656 merged by jenkins-bot:
Simplify the AbuseFilter configuration a little

https://gerrit.wikimedia.org/r/114656

Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Change 156081 had a related patch set uploaded by Withoutaname:
Move some permissions from abusefilter.php to InitialiseSettings.php

https://gerrit.wikimedia.org/r/156081

Change 156081 abandoned by Withoutaname:
Move some permissions from abusefilter.php to InitialiseSettings.php

Reason:
Agreed, I don't think this bug is worth the resources needed to solve it.

https://gerrit.wikimedia.org/r/156081

IMO we can RESOLVE this as this is not worth working on anymore (also I'm actually not opposing one configuration file per extension).