Page MenuHomePhabricator
Create Task
Maniphest T60264

wrong UUID to topic_list[offset-id] leads to silent 500 failures
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Description

I found the nifty topic_list[offset-id] parameter to scroll a particular topic into view. I think it takes the UUID of the previous workflow.

If you get it wrong as in the URL above, you see an empty browser window, and error.log contains

[Tue Dec 10 08:57:17 2013] [error] [client 76.14.58.232] PHP Catchable fatal error: Argument 1 passed to Flow\\Model\\TopicListEntry::toStorageRow() must be an instance of Flow\\Model\\TopicListEntry, null given in /srv/mediawiki/extensions/Flow/includes/Model/TopicListEntry.php on line 32

If you just give a garbled parameter like http://ee-flow.wmflabs.org/wiki/Talk:First_release?topic_list[offset-id]=bad , you at least get an exception error reported to the browser:

[1a4011a3] /wiki/Talk:First_release?topic_list[offset-id]=bad Exception from line 48 of /srv/mediawiki/extensions/Flow/includes/Model/UUID.php: Unknown input to UUID class

Maybe Flow should support a general query string parameter to make visible any topic or post, to fix bug 58251

Version: master
Severity: normal
URL: http://ee-flow.wmflabs.org/wiki/Talk:First_release?topic_list[offset-id]=050a0a1b3ef334dffb6efa163e68c4ac

Details

Reference
bz58264

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:38 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz58264.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Dec 10 2013, 9:59 AM
• bzimport added a comment.Dec 10 2013, 10:30 AM

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/603, but people from the community are welcome to contribute here and in Gerrit.

Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:39 AM
EBernhardson unsubscribed.Jul 18 2018, 6:44 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:44 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:09 PM
Krinkle closed this task as Declined.Oct 27 2018, 6:45 PM
Krinkle edited projects, added Wikimedia-production-error; removed Collaboration-Team-Triage.
Krinkle subscribed.

Not seen in the last 30 day of Logstash reports.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL