Details
- Reference
- bz58274
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T51120 implement ranks for statements | |||
Resolved | None | T46678 allow to change the order of statements | |||
Resolved | None | T54393 Enable sorting of statements | |||
Resolved | None | T54392 Sort statements within a statement group | |||
Invalid | None | T59918 [Story] show diffs for ordering changes | |||
Declined | • Jonas | T60274 [Task] Implement an order-aware MapDiffer |
Event Timeline
One problem with implementing this is that following the naive approach (representing a change in order as a remove and an insert operation), both such operations would have the same key in the (Map)Diff, so one would override the other. Also, for the insert operation, it would need some context specifying *where* to insert it.
An alternative approach is to represent the order explicitly as a list of keys, and attach that list as an extra field to the MapDiff.
Note that the class tree based in the Diff class contains some overburdened and some deprecated classes. Some refactoring may be in order.
Also, care must be taken to allow for reliably application of Diffs as patches.
(In reply to tobias.gritschacher from comment #4)
Reopen this to not forget it when not following the issues on GitHub.
Is this ticket still "highest priority" which was set half a year ago?
(In reply to tobias.gritschacher from comment #4)
Reopen this to not forget it when not following the issues on GitHub.
Is this ticket still "highest priority" which was set half a year ago? If yes, we might have different interpretations of highest priority. ;)