Page MenuHomePhabricator
Create Task
Maniphest T60280

AFT5: Character & word count broken for languages other than english
Closed, ResolvedPublic
Actions

Description

Reported by VIGNERON on frwiki ([[fr:Discussion Wikipédia:Outil de retour des lecteurs#Questions]])

He says that, in [[fr:Spécial:ArticleFeedbackv5/Autel de la Paix Auguste/050ab85686d4bd50ee7e782bcb087d2e]], the feedback is 'les caractéristiques', which is 20 characters long and contains 2 words.

But AFT5 says this string contains 21 characters and 3 words.

I read some feedbacks and I think AFT5 is counting bytes instead of characters, and consider 'é' is not a valid character for a word.

Version: unspecified
Severity: normal

Details

Reference
bz58280
SubjectRepoBranchLines +/-
str_word_count() struggles with UTF-8 characters, use a custom implementation instead that understands UTF-8mediawiki/extensions/ArticleFeedbackv5master+17 -2
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:39 AM
• bzimport added projects: ArticleFeedbackv5, I18n.
• bzimport set Reference to bz58280.
• bzimport added a subscriber: Unknown Object (MLST).
Ltrlg created this task.Dec 10 2013, 6:00 PM
Aklapper added a comment.Feb 28 2014, 4:35 PM

[Lowering priority to reflect reality, as AFTv5 is not very actively being worked on anymore.]

Jdforrester-WMF closed this task as Declined.Mar 5 2015, 10:03 PM
Jdforrester-WMF subscribed.

All development work on AbuseFilter v.5 (and indeed, previous versions) is halted. The project is archived, so having open tasks is inappropriate. Consequently, I'm closing all tasks.

SamanthaNguyen reopened this task as Open.Jan 2 2017, 1:34 AM
SamanthaNguyen moved this task from Backlog to Bugs on the ArticleFeedbackv5 board.
SamanthaNguyen edited subscribers, added: ashley, SamanthaNguyen; removed: • wikibugs-l-list.

Re-investigating per T146253

SamanthaNguyen unsubscribed.Jul 12 2017, 5:38 PM
Amire80 moved this task from Untriaged to Unicode support on the I18n board.Mar 24 2018, 7:06 PM
gerritbot added a comment.Jul 9 2019, 2:39 AM

Change 521407 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/ArticleFeedbackv5@master] str_word_count() struggles with UTF-8 characters, use a custom implementation instead that understands UTF-8

https://gerrit.wikimedia.org/r/521407

gerritbot added a project: Patch-For-Review.Jul 9 2019, 2:39 AM
gerritbot added a comment.Jul 13 2019, 7:03 PM

Change 521407 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] str_word_count() struggles with UTF-8 characters, use a custom implementation instead that understands UTF-8

https://gerrit.wikimedia.org/r/521407

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2019, 7:10 PM
ashley closed this task as Resolved.Jul 13 2019, 7:36 PM
ashley claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL